[release-1.33] Do Not Merge - revert crypto bump and use OCP crypto branch#6694
Draft
TomSweeneyRedHat wants to merge 2 commits into
Draft
[release-1.33] Do Not Merge - revert crypto bump and use OCP crypto branch#6694TomSweeneyRedHat wants to merge 2 commits into
TomSweeneyRedHat wants to merge 2 commits into
Conversation
TomSweeneyRedHat
added
do-not-merge/work-in-progress
No New Tests
dosubot
Bot
added
the
size:M
This reverts commit 2b88f58. Signed-off-by: Tom Sweeney <tsweeney@redhat.com>
Use the golang.org/x/crypto library from the OCP team located at: github.com/openshift/golang-crypto v0.33.1-0.20260212164730-3e9ce6e0b8f5 To try and keep Go at a version that is usable by the OCP team. Signed-off-by: Tom Sweeney <tsweeney@redhat.com>
TomSweeneyRedHat
force-pushed
the
dev/tsweeney/ocp_revert
branch
from
b913588 to
395d866
Compare
nalind
reviewed
Feb 26, 2026
|
|
||
| go 1.22.6 | ||
|
|
||
| toolchain go1.22.12 |
Member
There was a problem hiding this comment.
The toolchain line can probably be dropped. We usually try to not have one.
|
A friendly reminder that this PR had no activity for 30 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts 65707d0 from the release-1.33 branch and replaces golang.org/x/crypto with one that the OCP team has worked up to address CVE-2025-47913. This will keep Go at v1.22 in this branch, which is important to the OCP Builder team.
What type of PR is this?
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?