Add shared-memory-dict - #19855
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/shared-memory-dict:
|
|
I'm willing to be listed as a maintainer |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge/help-python, ready for review! |
|
@conda-forge/staged-recipes, ready for review! |
Co-authored-by: jakirkham <jakirkham@gmail.com>
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/shared-memory-dict:
|
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/shared-memory-dict:
|
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/shared-memory-dict:
|
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@BastianZim, I updated the recipe to follow sagemaker-inference-toolkit-feedstock like you suggested, but the import test in subsequent packages keeps failing. I don't know what else to try. |
|
I'm currently on my phone but I'll have a look in an hour or so. |
BastianZim
left a comment
There was a problem hiding this comment.
I can't see the error either but let's make sure that everything is in order and then I can try tracking it down.
Co-authored-by: Bastian Zimmermann <10774221+BastianZim@users.noreply.github.com>
Co-authored-by: Bastian Zimmermann <10774221+BastianZim@users.noreply.github.com>
BastianZim
left a comment
There was a problem hiding this comment.
I have added two small comments.
For the overall problem: I don't know unfortunately what is causing it but one thing I noticed in the logs is that pip installs the build tools (poetry etc) since they are not specified here. Upstream doesn't do that either though so I would first recommend asking them to add the build tools to their pyproject.toml.
You can also add --no-index to the build script which will maybe make it fail sooner.
Unfortunately, multi-output scripts are very finicky, so the error might be somewhere else.
@ocefpaf Have you seen this before and maybe have an idea?
Co-authored-by: Bastian Zimmermann <10774221+BastianZim@users.noreply.github.com>
Upstream does have |
|
Ahh true — must've missed that. Please add poetry to host then. |
Co-authored-by: Daniel Ching <carterbox@users.noreply.github.com>
|
Needed to add all of the special pip args that are set automatically in the top package. |
|
Thanks for all the help getting this merged! |
Checklist
url) rather than a repo (e.g.git_url) is used in your recipe (see here for more details).