Skip to content

Add shared-memory-dict - #19855

Merged
carterbox merged 25 commits into
conda-forge:mainfrom
maxb2:shared-memory-dict
Aug 28, 2022
Merged

Add shared-memory-dict#19855
carterbox merged 25 commits into
conda-forge:mainfrom
maxb2:shared-memory-dict

Conversation

@maxb2

@maxb2 maxb2 commented Jul 28, 2022

Copy link
Copy Markdown
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/shared-memory-dict) and found some lint.

Here's what I've got...

For recipes/shared-memory-dict:

  • The top level meta keys are in an unexpected order. Expecting ['package', 'source', 'build', 'test', 'outputs', 'about', 'extra'].

@maxb2

maxb2 commented Jul 28, 2022

Copy link
Copy Markdown
Contributor Author

I'm willing to be listed as a maintainer

@conda-forge-linter

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/shared-memory-dict) and found it was in an excellent condition.

@maxb2

maxb2 commented Jul 28, 2022

Copy link
Copy Markdown
Contributor Author

@conda-forge/help-python, ready for review!

@maxb2

maxb2 commented Aug 12, 2022

Copy link
Copy Markdown
Contributor Author

@conda-forge/staged-recipes, ready for review!

Comment thread recipes/shared-memory-dict/meta.yaml Outdated
Co-authored-by: jakirkham <jakirkham@gmail.com>
@conda-forge-linter

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/shared-memory-dict) and found some lint.

Here's what I've got...

For recipes/shared-memory-dict:

  • requirements: run: aiocache>=0.11.1,<0.12.0 must contain a space between the name and the pin, i.e. aiocache >=0.11.1,<0.12.0
  • requirements: run: aiocache>=0.11.1,<0.12.0 must contain a space between the name and the pin, i.e. aiocache >=0.11.1,<0.12.0
  • requirements: run: django>=3.0.8,<4.0.0 must contain a space between the name and the pin, i.e. django >=3.0.8,<4.0.0
  • requirements: run: django>=3.0.8,<4.0.0 must contain a space between the name and the pin, i.e. django >=3.0.8,<4.0.0

@conda-forge-linter

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/shared-memory-dict) and found it was in an excellent condition.

Comment thread recipes/shared-memory-dict/meta.yaml Outdated
@conda-forge-linter

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/shared-memory-dict) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/shared-memory-dict:

  • It looks like the 'shared-memory-dict-all' output doesn't have any tests.

@conda-forge-linter

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/shared-memory-dict) and found it was in an excellent condition.

@conda-forge-linter

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/shared-memory-dict) and found some lint.

Here's what I've got...

For recipes/shared-memory-dict:

  • The top level meta keys are in an unexpected order. Expecting ['package', 'source', 'build', 'requirements', 'test', 'outputs', 'about', 'extra'].

@conda-forge-linter

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/shared-memory-dict) and found it was in an excellent condition.

@maxb2

maxb2 commented Aug 25, 2022

Copy link
Copy Markdown
Contributor Author

@BastianZim, I updated the recipe to follow sagemaker-inference-toolkit-feedstock like you suggested, but the import test in subsequent packages keeps failing. I don't know what else to try.

@BastianZim

Copy link
Copy Markdown
Member

I'm currently on my phone but I'll have a look in an hour or so.

@BastianZim BastianZim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see the error either but let's make sure that everything is in order and then I can try tracking it down.

Comment thread recipes/shared-memory-dict/meta.yaml
Comment thread recipes/shared-memory-dict/meta.yaml Outdated
maxb2 and others added 2 commits August 25, 2022 14:48
Co-authored-by: Bastian Zimmermann <10774221+BastianZim@users.noreply.github.com>
Co-authored-by: Bastian Zimmermann <10774221+BastianZim@users.noreply.github.com>

@BastianZim BastianZim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added two small comments.

For the overall problem: I don't know unfortunately what is causing it but one thing I noticed in the logs is that pip installs the build tools (poetry etc) since they are not specified here. Upstream doesn't do that either though so I would first recommend asking them to add the build tools to their pyproject.toml.

You can also add --no-index to the build script which will maybe make it fail sooner.

Unfortunately, multi-output scripts are very finicky, so the error might be somewhere else.

@ocefpaf Have you seen this before and maybe have an idea?

Comment thread recipes/shared-memory-dict/meta.yaml Outdated
Comment thread recipes/shared-memory-dict/meta.yaml Outdated
maxb2 and others added 2 commits August 26, 2022 10:16
Co-authored-by: Bastian Zimmermann <10774221+BastianZim@users.noreply.github.com>
@maxb2

maxb2 commented Aug 26, 2022

Copy link
Copy Markdown
Contributor Author

For the overall problem: I don't know unfortunately what is causing it but one thing I noticed in the logs is that pip installs the build tools (poetry etc) since they are not specified here. Upstream doesn't do that either though so I would first recommend asking them to add the build tools to their pyproject.toml.

Upstream does have poetry set as the build backend, but it is using the old way to do it. I submitted a PR to update it.

@BastianZim

Copy link
Copy Markdown
Member

Ahh true — must've missed that. Please add poetry to host then.

Comment thread recipes/shared-memory-dict/meta.yaml
maxb2 and others added 3 commits August 26, 2022 16:52
@carterbox

Copy link
Copy Markdown
Member

Needed to add all of the special pip args that are set automatically in the top package.

@carterbox
carterbox merged commit b7110e5 into conda-forge:main Aug 28, 2022
@maxb2

maxb2 commented Aug 28, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for all the help getting this merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants