twig/twig patches - #24
Merged
Merged
Conversation
wordish
approved these changes
May 26, 2026
wordish
left a comment
There was a problem hiding this comment.
LGTM, assume these are all copy/paste from source without modification. The inversion of logic in 2026-46638 looked particularly scary if it was an accident.
|
|
||
| // in a sandbox tag, only include tags are allowed | ||
| - if (!$body instanceof IncludeNode) { | ||
| + if ($body instanceof IncludeNode) { |
Member
Author
There was a problem hiding this comment.
Yeah, as crazy as it looks that's part of the original commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
composer.jsonpatches fortwig/twigto version 3.11.3, adding several important security and documentation patches. These changes address multiple CVEs, improving the security of template rendering, sandboxing, and profiling in Twig. The most important changes are grouped below:Security Fixes:
template_from_string()in sandboxed environments, warning that it can bypass sandbox policies and lead to untrusted code execution.usetag by escaping single quotes in compiled template names and improving error handling.spacelessfilter pre-escapes HTML input, preventing XSS when the filter is used with untrusted input.Patch Management:
composer.jsonto include and reference all the above patches fortwig/twigversion 3.11.3.