#3907: add component info in conanfile.py, add cmake helper module, e… by wdobbe · Pull Request #3908 · conan-io/conan-center-index

wdobbe · 2020-12-15T18:42:22Z

Specify library name and version: flatcc/0.6.0

added component information
added a cmake module with cmake helper function
fixed a cross-compile problem

Resolves #3907

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

…odule, export location of build arch flatcc exe when cross-compiling

madebr · 2020-12-15T20:56:16Z

-            self.cpp_info.libs.append("flatcc%s" % debug_suffix)
-        self.cpp_info.libs.append("flatccrt%s" % debug_suffix)
+            self.cpp_info.components["flatcc_exe"].names["cmake_find_package"] = "flatcc_exe"
+            self.cpp_info.components["flatcc_exe"].libs = ["flatcc%s" % debug_suffix]


If flatcc_exe is the compiler binary, shouldn't .libs be empty then?

Yes, I will add an extra component for the library that the compiler binary links to.

madebr · 2020-12-15T20:58:07Z

@@ -0,0 +1,88 @@
+


Can you please point me to the cmake script from the flatbuffers repo at https://github.com/dvidelabs/flatcc
containing these functions/macros?

I wrote that cmake script because it simplifies using flatcc in cmake a lot. I am going to send it upstream as well.
Do you want me to add it to the flatcc package via the patches mechanism?

Edit: PR for flatcc cmake module submitted: dvidelabs/flatcc#169

Please do it as a patch, so when your pr gets accepted, this recipe can be adapted more easily.
In the mean time, maybe add a FIXME/TODO that this is experimental conan-only code?

…component, add cmake helper module via patch

wdobbe · 2020-12-16T16:51:25Z

PR paused due to discussion and modifications of the upstream PR.
I will continue this PR once the upstream one is finalised.

wdobbe · 2020-12-20T14:45:44Z

@madebr With the recent changes in your flatcc cmake_dep branch, should I add two components in the flatcc Conan recipe:

cli
runtime

That would implicate that I have to add the compiler lib to component cli.

madebr · 2020-12-20T15:00:02Z

@wdobbe

With the recent changes in your flatcc cmake_dep branch, should I add two components in the flatcc Conan recipe:
* cli
* runtime
That would implicate that I have to add the compiler lib to component cli.

Indeed, 2 components flatcc:cli for libflatcc and flatcc::runtime for libflatccrt. (with _d suffix for debug)
flatcc::cli is currently not supported by conan. For now, you need to replace it with a path to the executable.
There is work to add support though.

BTW, the installed cmake scripts are perfectly relocatable.
So removing them in your private conan recipes is not needed.

wdobbe · 2020-12-20T15:11:56Z

Thanks.
But this is a pull request for the flatcc recipe to conan-center-index so I suppose I have to remove the cmake config files ?

madebr · 2020-12-20T15:35:24Z

Indeed, and keep the FlatccGenerateSources.cmake file.

…madebr's cmake_dep branch until merged upstream. Note this is work-in-progress, not to be merged until new flatcc release is available

wdobbe · 2020-12-20T16:46:11Z

I have modified the flatcc Conan recipe to the modified flatcc cmake. Temporarily it fetches your cmake_dep branch.
In the package() function I replace the flatcc::cli target in FlatccGenerateSources.cmake with $ENV{FLATCC_CLI_EXE} (until Conan supports such an executable target).
The FLATCC_CLI_EXE environment variable is set by the Conan recipe to the correct build/host executable also when cross-compiling.

This works fine with command conan create commands both when compiling native and when cross-compiling. However when you want to build your package (that uses flatcc) yourself with

conan install <source_dir>
cmake ....
cmake --build ....

the environment variable FLATCC_CLI_EXE is not set and the build fails :-(

madebr · 2020-12-20T18:05:45Z

        # Copy license file
        self.copy("LICENSE", dst="licenses", src=self._source_subfolder)
+        # Remove cmake config files
+        tools.rmdir(os.path.join(self.package_folder, "lib", "cmake", "flatcc"))


Is flatcc present at install time?

Nevermind, it is!!!! Doh.

madebr · 2020-12-20T18:06:28Z

                      os.path.join(self.package_folder, "bin", "flatcc"))
        # Copy license file
        self.copy("LICENSE", dst="licenses", src=self._source_subfolder)
+        # Remove cmake config files


Alternatively, move the files you want to keep to some temporary folder, remove os.path.join(self.package_folder("lib", "cmake")) and re-create a cmake folder

madebr · 2020-12-20T18:07:13Z

+        genSourcesMod = os.path.join(self.package_folder, "lib", "cmake", "flatcccli", "FlatccGenerateSources.cmake")
+        tools.replace_in_file(genSourcesMod, "flatcc::cli", "$ENV{FLATCC_CLI_EXE}", strict=True)


You can do this in a patch before the build.
The script you're patching is only used in the samples and tests.
So when disabling those, the file is not used.

Ok, I'll add a patch.
The file is also used by packages that use flatcc by the way.

Maybe do a tools.replace (for the moment).
The branch will undergo more changes.

I just added the patch...

madebr · 2020-12-20T18:09:37Z

        if not self.options.runtime_lib_only:
-            self.cpp_info.libs.append("flatcc%s" % debug_suffix)
-        self.cpp_info.libs.append("flatccrt%s" % debug_suffix)
+            self.cpp_info.components["cli"].names["cmake_find_package"] = "cli"


Maybe add a FIXME about missing flatcccli and flatccruntime (2 files) instead of one
Conan is missing this feature.
Also FIXME about missing flatcc::cli target.

Maybe add a FIXME about missing flatcccli and flatccruntime (2 files) instead of one

Can you elaborate a bit? What exactly is missing ?

Also FIXME about missing flatcc::cli target

Ok, I'll add a comment that flatcc::cli executable target currently doesn't work with Conan.

Maybe it's unnecessary, but right now it's installing 3 cmake packages:
flatcc-config.cmake, flatcccli-config.cmake and flatccruntime-config.cmake. Of these, currently only flatcc-config.cmake` is re-created by conan.

But aren't flatcccli-config.cmake and flatccruntime-config.cmake more like 'internal' config files?
End-users should use find_package(flatcc).

I've documented flatcccli for cross building purposes.
But anyhow, maybe add a FIXME/TODO for when conan receives support for creating multiple cmake modules.

I've documented flatcccli for cross building purposes.

I noticed. Further down in the README there is also a section called 'Cross-compilation' that I am updating now. Will create a pull request to your branch when done tomorrow.

But anyhow, maybe add a FIXME/TODO for when conan receives support for creating multiple cmake modules.

Will do.

madebr · 2020-12-20T18:10:44Z

-        COMMAND cmake -E make_directory "${GEN_DIR}"
-        COMMAND flatcc -a -o "${GEN_DIR}" "${FBS_DIR}/monster.fbs"
-        DEPENDS flatcc "${FBS_DIR}/monster.fbs"
+if (MACOS_SIP_WORKAROUND)


Make sure that cmake in test_package/conanfile.py is only run when not tools.cross_building(self.settings) is true.

Alternative is adding flatcc as build requirement in test_package/conanfile.py, but then when increasing the version in conanfile.py you have to remember to update the flatcc version in test_package/conanfile.py as well.

@@ -6,6 +6,7 @@ from conans import ConanFile, CMake, tools, RunEnvironment class FlatccTestConan(ConanFile): settings = "os", "compiler", "build_type", "arch" generators = "cmake" + build_requires = "flatcc/0.7.0pre"

Wait, that won't work because the flatcc version in build_requires should be the same as the injected flatcc requirement.

The test_package (=running flatcc::cli) only works when not cross building.
I haven't tested, but maybe add

def build_requirements(self): if tools.cross_building(self.settings): self.build_requires("flatcc/{}"/format(some_version)

But I don't think conan supports this.
I haven't seen recipes doing this. Maybe ask @jgsogo, the conan xbuild professional.

I already tried to retrieve the flatcc version that is tested from self.requires (since Conan injects it for the test_package). But both in config_options() and configure() self.requires is empty.

I'll ask @jgsogo , else the following works when not using strange versions like 0.7.0pre:
build_requires = ("flatcc/[>=0.7.0]")

That might work, but is not really reproducible.
There should be some way to know what package a test recipe is testing.
e.g. as self.test_package that is available as soon as possible.

Not a big fan of this interface, but it is documented: you can use self.deps_cpp_info["requirements"].version in the build() to get the version of the requirement (after the graph is resolved). Is this what you are looking for?

Conan injects the requirement automatically, but after that line, it is a regular requirement.

Hi @jgsogo ,

What we are looking for is finding out the version of the package that is being tested at a point where we can inject a build_requirement for the same package/version.

In order to build the test_package for flatcc (and similar tools) when cross-compiling, flatcc is also needed in the build architecture to generate the flatbuffer header files. Then the test executable is linked to the flatcc host arch library.

I suppose in the build() function it is too late to inject a build_requirement. Is it possible to do that earlier ?

I see.

This is not possible today. The recipe in the test_package works like any other recipe. The version of a requirement can be overridden by other branches of the graph (overrides, version-ranges, diamonds), so the final version of a requirement is only known when the graph is fully resolved and this is exactly the scenarios where the new validate() function plays an important role.

BUT, I agree this is a test_package and it totally makes sense to know the recipe being tested. And probably Conan should forbid modifying options in the test_package too (conan-io/conan#7547). These (together with a proposal to test build-requires using the two-profiles approach conan-io/conan#7132) are things that we should explore before Conan v2.

Would you mind opening an issue with this feature request?

Meanwhile, I cannot see a documented way to achieve this behavior.

madebr · 2020-12-20T18:11:51Z

+if (MACOS_SIP_WORKAROUND)
+    set(INC_DIR "${PROJECT_SOURCE_DIR}/include")
+    set(GEN_DIR "${CMAKE_CURRENT_BINARY_DIR}/generated")
+    include_directories("${GEN_DIR}" "${INC_DIR}")


Is this SIP workaround still needed for the latest version?
flatcc does not depend on an external (shared) library.
And I made sure to set a relative RPATH on the executable.

Maybe change the if to include a version comparison/conditional?

Flatcc depends on the flatcc compiler shared lib when configuring with BUILD_SHARED_LIBS=On. The SIP workaround is only used then:
if tools.os_info.is_macos and self.options["flatcc"].shared:

Its very well possible that the workaround is not needed anymore now that RPATH is set but at the moment I don't have access to a Mac that is recent enough to have SIP. I can check next week at work.

Please do, or just let c3i test it for you 😛
SIP causes problems only when it needs external DYLD_LIBRARY_PATH, which is not the case here.

Unless cmake is configured to not set RPATH on install, which is possible:
https://cmake.org/cmake/help/latest/variable/CMAKE_SKIP_INSTALL_RPATH.html

Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>

stale · 2021-01-21T15:51:04Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale · 2021-04-06T22:17:41Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

wdobbe · 2021-04-07T10:54:31Z

This PR is waiting for merge of flatcc PR #171.
Please don't close it yet.

stale · 2021-05-08T02:50:25Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

jgsogo · 2021-05-08T16:35:49Z

It looks like dvidelabs/flatcc#171 is still being considered.

stale · 2021-06-07T17:05:17Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

madebr · 2021-06-07T18:26:47Z

Still waiting on upstream..

conan-center-bot · 2021-06-28T11:08:36Z

Failure in build 12 (6c630aa4571ba79ceb897fac27dd791a3532bc24):

flatcc/0.6.0@:
CI failed to create some packages (All logs)

Logs for packageID 0519b288ae4d60e7272202b879e060bd0cd01b93:

[settings]
arch=x86_64
arch_build=x86_64
build_type=Release
compiler=apple-clang
compiler.libcxx=libc++
compiler.version=12.0
os=Macos
os_build=Macos
[options]
flatcc:shared=False

[...]
-- Installing: /Users/jenkins/w/BuildSingleReference@3/.conan/data/flatcc/0.6.0/_/_/package/0519b288ae4d60e7272202b879e060bd0cd01b93/include/flatcc/portable/grisu3_math.h
-- Installing: /Users/jenkins/w/BuildSingleReference@3/.conan/data/flatcc/0.6.0/_/_/package/0519b288ae4d60e7272202b879e060bd0cd01b93/include/flatcc/portable/pstdint.h
-- Installing: /Users/jenkins/w/BuildSingleReference@3/.conan/data/flatcc/0.6.0/_/_/package/0519b288ae4d60e7272202b879e060bd0cd01b93/include/flatcc/portable/pstdbool.h
-- Installing: /Users/jenkins/w/BuildSingleReference@3/.conan/data/flatcc/0.6.0/_/_/package/0519b288ae4d60e7272202b879e060bd0cd01b93/include/flatcc/portable/pstatic_assert_scope.h
-- Installing: /Users/jenkins/w/BuildSingleReference@3/.conan/data/flatcc/0.6.0/_/_/package/0519b288ae4d60e7272202b879e060bd0cd01b93/include/flatcc/portable/grisu3_parse.h
-- Installing: /Users/jenkins/w/BuildSingleReference@3/.conan/data/flatcc/0.6.0/_/_/package/0519b288ae4d60e7272202b879e060bd0cd01b93/include/flatcc/portable/pparseint.h
-- Installing: /Users/jenkins/w/BuildSingleReference@3/.conan/data/flatcc/0.6.0/_/_/package/0519b288ae4d60e7272202b879e060bd0cd01b93/include/flatcc/flatcc_endian.h
-- Installing: /Users/jenkins/w/BuildSingleReference@3/.conan/data/flatcc/0.6.0/_/_/package/0519b288ae4d60e7272202b879e060bd0cd01b93/include/flatcc/flatcc_iov.h
-- Installing: /Users/jenkins/w/BuildSingleReference@3/.conan/data/flatcc/0.6.0/_/_/package/0519b288ae4d60e7272202b879e060bd0cd01b93/include/flatcc/flatcc_rtconfig.h
-- Installing: /Users/jenkins/w/BuildSingleReference@3/.conan/data/flatcc/0.6.0/_/_/package/0519b288ae4d60e7272202b879e060bd0cd01b93/include/flatcc/flatcc_accessors.h
-- Installing: /Users/jenkins/w/BuildSingleReference@3/.conan/data/flatcc/0.6.0/_/_/package/0519b288ae4d60e7272202b879e060bd0cd01b93/include/flatcc/flatcc_epilogue.h
-- Installing: /Users/jenkins/w/BuildSingleReference@3/.conan/data/flatcc/0.6.0/_/_/package/0519b288ae4d60e7272202b879e060bd0cd01b93/include/flatcc/flatcc_identifier.h
-- Installing: /Users/jenkins/w/BuildSingleReference@3/.conan/data/flatcc/0.6.0/_/_/package/0519b288ae4d60e7272202b879e060bd0cd01b93/include/flatcc/flatcc_prologue.h
-- Installing: /Users/jenkins/w/BuildSingleReference@3/.conan/data/flatcc/0.6.0/_/_/package/0519b288ae4d60e7272202b879e060bd0cd01b93/include/flatcc/flatcc_builder.h
-- Installing: /Users/jenkins/w/BuildSingleReference@3/.conan/data/flatcc/0.6.0/_/_/package/0519b288ae4d60e7272202b879e060bd0cd01b93/include/flatcc/support
-- Installing: /Users/jenkins/w/BuildSingleReference@3/.conan/data/flatcc/0.6.0/_/_/package/0519b288ae4d60e7272202b879e060bd0cd01b93/include/flatcc/support/README
-- Installing: /Users/jenkins/w/BuildSingleReference@3/.conan/data/flatcc/0.6.0/_/_/package/0519b288ae4d60e7272202b879e060bd0cd01b93/include/flatcc/support/readfile.h
-- Installing: /Users/jenkins/w/BuildSingleReference@3/.conan/data/flatcc/0.6.0/_/_/package/0519b288ae4d60e7272202b879e060bd0cd01b93/include/flatcc/support/cdump.h
-- Installing: /Users/jenkins/w/BuildSingleReference@3/.conan/data/flatcc/0.6.0/_/_/package/0519b288ae4d60e7272202b879e060bd0cd01b93/include/flatcc/support/elapsed.h
-- Installing: /Users/jenkins/w/BuildSingleReference@3/.conan/data/flatcc/0.6.0/_/_/package/0519b288ae4d60e7272202b879e060bd0cd01b93/include/flatcc/support/hexdump.h
-- Installing: /Users/jenkins/w/BuildSingleReference@3/.conan/data/flatcc/0.6.0/_/_/package/0519b288ae4d60e7272202b879e060bd0cd01b93/include/flatcc/flatcc_json_parser.h
-- Installing: /Users/jenkins/w/BuildSingleReference@3/.conan/data/flatcc/0.6.0/_/_/package/0519b288ae4d60e7272202b879e060bd0cd01b93/include/flatcc/flatcc_flatbuffers.h
-- Installing: /Users/jenkins/w/BuildSingleReference@3/.conan/data/flatcc/0.6.0/_/_/package/0519b288ae4d60e7272202b879e060bd0cd01b93/include/flatcc/flatcc_portable.h
-- Installing: /Users/jenkins/w/BuildSingleReference@3/.conan/data/flatcc/0.6.0/_/_/package/0519b288ae4d60e7272202b879e060bd0cd01b93/include/flatcc/flatcc_types.h
-- Installing: /Users/jenkins/w/BuildSingleReference@3/.conan/data/flatcc/0.6.0/_/_/package/0519b288ae4d60e7272202b879e060bd0cd01b93/include/flatcc/reflection
-- Installing: /Users/jenkins/w/BuildSingleReference@3/.conan/data/flatcc/0.6.0/_/_/package/0519b288ae4d60e7272202b879e060bd0cd01b93/include/flatcc/reflection/README
-- Installing: /Users/jenkins/w/BuildSingleReference@3/.conan/data/flatcc/0.6.0/_/_/package/0519b288ae4d60e7272202b879e060bd0cd01b93/include/flatcc/reflection/reflection_reader.h
-- Installing: /Users/jenkins/w/BuildSingleReference@3/.conan/data/flatcc/0.6.0/_/_/package/0519b288ae4d60e7272202b879e060bd0cd01b93/include/flatcc/reflection/flatbuffers_common_reader.h
-- Installing: /Users/jenkins/w/BuildSingleReference@3/.conan/data/flatcc/0.6.0/_/_/package/0519b288ae4d60e7272202b879e060bd0cd01b93/include/flatcc/reflection/reflection_builder.h
-- Installing: /Users/jenkins/w/BuildSingleReference@3/.conan/data/flatcc/0.6.0/_/_/package/0519b288ae4d60e7272202b879e060bd0cd01b93/include/flatcc/reflection/reflection_verifier.h
-- Installing: /Users/jenkins/w/BuildSingleReference@3/.conan/data/flatcc/0.6.0/_/_/package/0519b288ae4d60e7272202b879e060bd0cd01b93/include/flatcc/reflection/flatbuffers_common_builder.h
-- Installing: /Users/jenkins/w/BuildSingleReference@3/.conan/data/flatcc/0.6.0/_/_/package/0519b288ae4d60e7272202b879e060bd0cd01b93/lib/libflatccrt.a
-- Installing: /Users/jenkins/w/BuildSingleReference@3/.conan/data/flatcc/0.6.0/_/_/package/0519b288ae4d60e7272202b879e060bd0cd01b93/lib/libflatcc.a
-- Installing: /Users/jenkins/w/BuildSingleReference@3/.conan/data/flatcc/0.6.0/_/_/package/0519b288ae4d60e7272202b879e060bd0cd01b93/bin/flatcc
CMake Warning:
  Manually-specified variables were not used by the project:

    CMAKE_EXPORT_NO_PACKAGE_REGISTRY
    CMAKE_INSTALL_BINDIR
    CMAKE_INSTALL_DATAROOTDIR
    CMAKE_INSTALL_INCLUDEDIR
    CMAKE_INSTALL_LIBDIR
    CMAKE_INSTALL_LIBEXECDIR
    CMAKE_INSTALL_OLDINCLUDEDIR
    CMAKE_INSTALL_SBINDIR


ERROR: flatcc/0.6.0: Error in package() method, line 111
	os.remove(os.path.join(self.package_folder, "lib", "cmake", "flatcccli", "flatcccli-config.cmake"))
	FileNotFoundError: [Errno 2] No such file or directory: '/Users/jenkins/w/BuildSingleReference@3/.conan/data/flatcc/0.6.0/_/_/package/0519b288ae4d60e7272202b879e060bd0cd01b93/lib/cmake/flatcccli/flatcccli-config.cmake'

flatcc/0.7.0pre@:
CI failed to create some packages (All logs)

Logs for packageID 0519b288ae4d60e7272202b879e060bd0cd01b93:

[settings]
arch=x86_64
arch_build=x86_64
build_type=Release
compiler=apple-clang
compiler.libcxx=libc++
compiler.version=12.0
os=Macos
os_build=Macos
[options]
flatcc:shared=False

********************************************************************************
conan install flatcc/0.7.0pre@ --build=flatcc --profile=/Users/jenkins/w/BuildSingleReference@3/20502/23e62d91-0597-43ee-9dfc-dc2b6f706cbd/profile.txt
********************************************************************************
Configuration:
[settings]
arch=x86_64
arch_build=x86_64
build_type=Release
compiler=apple-clang
compiler.libcxx=libc++
compiler.version=12.0
os=Macos
os_build=Macos
[options]
flatcc:shared=False
[build_requires]
[env]

flatcc/0.7.0pre: Forced build from source
Installing package: flatcc/0.7.0pre
Requirements
    flatcc/0.7.0pre from local cache - Cache
Packages
    flatcc/0.7.0pre:0519b288ae4d60e7272202b879e060bd0cd01b93 - Build

Installing (downloading, building) binaries...
[HOOK - conan-center.py] pre_source(): [IMMUTABLE SOURCES (KB-H010)] OK
flatcc/0.7.0pre: Configuring sources in /Users/jenkins/w/BuildSingleReference@3/.conan/data/flatcc/0.7.0pre/_/_/source
flatcc/0.7.0pre: WARN: Build folder is dirty, removing it: /Users/jenkins/w/BuildSingleReference@3/.conan/data/flatcc/0.7.0pre/_/_/build/0519b288ae4d60e7272202b879e060bd0cd01b93
flatcc/0.7.0pre: WARN: Trying to remove corrupted source folder
flatcc/0.7.0pre: WARN: This can take a while for big packages
ERROR: flatcc/0.7.0pre: Error in source() method, line 70
	tools.get(**self.conan_data["sources"][self.version])
	ConanException: sha256 signature failed for 'cmake_dep.zip' file. 
 Provided signature: 78522f33d35efe291896b8a5b69b1752eadcd126a259522543cbc7f527772471  
 Computed signature: 9db360932e5f568ec44942ac96ee0cbc4dffb2fb4f19b669993bb728498ddc5c

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

stale · 2021-07-28T12:17:34Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale · 2021-08-27T15:25:04Z

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

conan-io#3907: add component info in conanfile.py, add cmake helper m…

170951c

…odule, export location of build arch flatcc exe when cross-compiling

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Dec 15, 2020

madebr reviewed Dec 15, 2020

View reviewed changes

conan-io#3907: apply PR feedback, add flatcc compiler lib in its own …

7230038

…component, add cmake helper module via patch

This comment has been minimized.

Sign in to view

conan-io#3907: upgrade minimum required cmake version in test_package

0d2bed3

This comment has been minimized.

Sign in to view

conan-io#3907: let Conan know that cmake subdir is intended

7b5e3ae

This comment has been minimized.

Sign in to view

conan-io#3907: rewrite recipe after many cmake changes upstream, use …

4fa8c6b

…madebr's cmake_dep branch until merged upstream. Note this is work-in-progress, not to be merged until new flatcc release is available

This comment has been minimized.

Sign in to view

conan-io#3907: add version 0.7.0pre also to config.yml

3421de3

This comment has been minimized.

Sign in to view

madebr reviewed Dec 20, 2020

View reviewed changes

Comment thread recipes/flatcc/all/conanfile.py Outdated

madebr reviewed Dec 20, 2020

View reviewed changes

Comment thread recipes/flatcc/all/conanfile.py Outdated

madebr reviewed Dec 20, 2020

View reviewed changes

Comment thread recipes/flatcc/all/conanfile.py Outdated

madebr reviewed Dec 20, 2020

View reviewed changes

wdobbe and others added 3 commits December 20, 2020 19:26

Make source subdir rename work with different branches.

e2c00ef

Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>

Improve patching command

84f3b23

Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>

Remove cmake config files more efficiently

76a6068

Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>

This comment has been minimized.

Sign in to view

Implement PR feedback from @madebr

6c630aa

This comment has been minimized.

Sign in to view

This was referenced Jan 6, 2021

[service] Potentially conflicting recipes #3571

Closed

[flatcc] fix hooks and conventions #4123

Merged

stale Bot added the stale label Jan 21, 2021

This comment has been minimized.

Sign in to view

stale Bot removed the stale label Mar 7, 2021

stale Bot added the stale label Apr 6, 2021

stale Bot removed the stale label Apr 7, 2021

stale Bot added the stale label May 8, 2021

stale Bot removed the stale label May 8, 2021

stale Bot added the stale label Jun 7, 2021

stale Bot removed the stale label Jun 7, 2021

stale Bot added the stale label Jul 28, 2021

stale Bot closed this Aug 27, 2021

		genSourcesMod = os.path.join(self.package_folder, "lib", "cmake", "flatcccli", "FlatccGenerateSources.cmake")
		tools.replace_in_file(genSourcesMod, "flatcc::cli", "$ENV{FLATCC_CLI_EXE}", strict=True)

Uh oh!

Conversation

wdobbe commented Dec 15, 2020

Uh oh!

This comment has been minimized.

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

wdobbe commented Dec 16, 2020

Uh oh!

wdobbe commented Dec 20, 2020

Uh oh!

madebr commented Dec 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wdobbe commented Dec 20, 2020

Uh oh!

madebr commented Dec 20, 2020

Uh oh!

This comment has been minimized.

wdobbe commented Dec 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

madebr Dec 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

madebr commented Dec 20, 2020 •

edited

Loading

wdobbe commented Dec 20, 2020 •

edited

Loading

madebr Dec 20, 2020 •

edited

Loading

madebr Dec 20, 2020 •

edited

Loading