Repository navigation
cli: honest edge cases in bench results tables (part 2) - #530
Merged
Merged
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
HeyGarrison
marked this pull request as ready for review
October 21, 2026 20:44
Contributor License AgreementAll contributors are covered by a CLA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #529's honesty fixes — closes the three residual edges Devin Review found on the merged commit:
fmtMs: a positive latency under 0.005 ms rounded to0viatoFixed(2)— now renders<0.01instead of reporting zero for a nonzero measurement.fmtRate: rates in [99.95%, 100%) rendered100.0%— whentoFixed(1)would print100.0for an imperfect run, fall back to99.9%(understates slightly, never shows 100 with failures).printResultsTablesoverview: when EVERY run had zero participants,rows.length === 0returned "No results." beforeemptyRunsprinted — the per-run "no participant results (analytics: …)" lines are now emitted before the early return, so empty runs are always named.Link to Devin session: https://app.devin.ai/sessions/809b5c17756b42deaabce9d017a4c14c
Open in Devin Desktop: https://app.devin.ai/desktop/session/809b5c17756b42deaabce9d017a4c14c?variant=devin
Requested by: @HeyGarrison