Skip to content

cli: honest edge cases in bench results tables (part 2) - #530

Merged
HeyGarrison merged 1 commit into
masterfrom
devin/1792615244-results-table-edges
Oct 21, 2026
Merged

HeyGarrison merged 1 commit into
masterfrom
devin/1792615244-results-table-edges

Conversation

@HeyGarrison

Copy link
Copy Markdown
Collaborator

Summary

Follow-up to #529's honesty fixes — closes the three residual edges Devin Review found on the merged commit:

  • fmtMs: a positive latency under 0.005 ms rounded to 0 via toFixed(2) — now renders <0.01 instead of reporting zero for a nonzero measurement.
  • fmtRate: rates in [99.95%, 100%) rendered 100.0% — when toFixed(1) would print 100.0 for an imperfect run, fall back to 99.9% (understates slightly, never shows 100 with failures).
  • printResultsTables overview: when EVERY run had zero participants, rows.length === 0 returned "No results." before emptyRuns printed — the per-run "no participant results (analytics: …)" lines are now emitted before the early return, so empty runs are always named.

Link to Devin session: https://app.devin.ai/sessions/809b5c17756b42deaabce9d017a4c14c
Open in Devin Desktop: https://app.devin.ai/desktop/session/809b5c17756b42deaabce9d017a4c14c?variant=devin
Requested by: @HeyGarrison

@devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@HeyGarrison
HeyGarrison marked this pull request as ready for review October 21, 2026 20:44
@HeyGarrison
HeyGarrison merged commit ba1680d into master Oct 21, 2026
2 checks passed
@open-cla

open-cla Bot commented Oct 21, 2026

Copy link
Copy Markdown

Contributor License Agreement

All contributors are covered by a CLA.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant