BUG: Log retrieve progress at debug level - #1448
Merged
Merged
Conversation
updateRetrieveProgress() is called for every progress tick, so an error-level trace message floods the log of any application that embeds ctkDICOMQueryRetrieveWidget.
Member
|
@Punzo is this error-level logging intentional? |
Contributor
@lassoan I don't use this widget in the visual dicom browser and I have not really updated it. In commit 88ff72b I have only updated the widget to use the latest API from the logic classes (ctkDICOMQuery and ctkDICOMRetrieve). I would agree with @kislinsk that the logger there should be set as debug (or even removed). |
lassoan
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer: We (MITK) are currently catching up on the latest CTK master branch
since we forked for Qt 6 back in 2023. We found a few bugs that are not caught by
your CI and mostly affect external users of CTK.
ctkDICOMQueryRetrieveWidget::updateRetrieveProgress()logs at errorlevel on every progress tick:
logger.error(QString("setting value to %1").arg(value));Any application embedding
ctkDICOMQueryRetrieveWidgetgets its log floodedduring a retrieve. One-line change to
logger.debug.