Skip to content

Split bootkick and watchdog into source files#2398

Open
KaannKara wants to merge 1 commit into
commaai:masterfrom
KaannKara:refactor-watchdog-bootkick-sources
Open

Split bootkick and watchdog into source files#2398
KaannKara wants to merge 1 commit into
commaai:masterfrom
KaannKara:refactor-watchdog-bootkick-sources

Conversation

@KaannKara
Copy link
Copy Markdown

@KaannKara KaannKara commented May 12, 2026

Summary:

  • Move the bootkick implementation out of bootkick.h and into bootkick.c.
  • Move the simple watchdog implementation out of simple_watchdog.h and into simple_watchdog.c.
  • Keep the existing driver declarations available through drivers.h while compiling the new source files into the panda H7 target.
  • Add an inline MISRA suppression for the existing GPIO pullup shift invariant now exercised by the split build.

Refs #2171
/claim #2171

Tests:

  • uv run --python 3.12 --extra dev scons -j2
  • uv run --python 3.12 --extra dev ruff check .
  • PATH=.venv/bin:$PATH PYTHONPATH=.. SKIP_TABLES_DIFF=1 tests/misra/test_misra.sh
  • PATH=.venv/bin:$PATH PYTHONPATH=.. pytest tests/usbprotocol
  • GitHub Actions tests workflow: build, macOS ./test.sh, Ubuntu ./test.sh, and Windows pip package test all passing.

@KaannKara KaannKara force-pushed the refactor-watchdog-bootkick-sources branch from 3660f11 to b688294 Compare May 12, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant