Skip to content

Feature/reserve identifier with new issue url#118

Open
dxL1nus wants to merge 25 commits into
codecheckers:mainfrom
dxL1nus:feature/reserve-identifier-with-new-issue-url
Open

Feature/reserve identifier with new issue url#118
dxL1nus wants to merge 25 commits into
codecheckers:mainfrom
dxL1nus:feature/reserve-identifier-with-new-issue-url

Conversation

@dxL1nus
Copy link
Copy Markdown
Contributor

@dxL1nus dxL1nus commented May 3, 2026

Closes #99,
closes #62,
closes #53,
closes #104,
closes #55,
closes #100,
closes #101,
closes #125

This PR is a massive one, but needed as most of the functionality is based upon each other, although there are a number of features addressed here.

Features that come with this PR:

  • Reserving identifiers with a GitHub New Issue URL Link
  • Linking manually created GtiHub Issue to the Certificate Identifier in OJS Submission
  • Update the information in the GitHub Issue (on metadata form save)
  • Delete concept of Venue Type & Venue Name as Labels (instead all labels in one central Dropdown)
    • Labels are cached / saved in the OJS DB (and only fetched from the API, when they are older than 6 hours)

❗ I want to include a setting in the settings form for a feature which is only introduced with this PR here (#101).

@dxL1nus dxL1nus requested a review from nuest May 3, 2026 16:47
@dxL1nus dxL1nus marked this pull request as draft May 3, 2026 16:48
@dxL1nus
Copy link
Copy Markdown
Contributor Author

dxL1nus commented May 3, 2026

so far this is a draft, because all parts are finished except for Issue #100. @nuest do we need this issue here in this stage already or can it be introduced at a later stage, so we can merge this PR. What do you think?

@dxL1nus
Copy link
Copy Markdown
Contributor Author

dxL1nus commented May 3, 2026

Plus it is a draft still, because I need to fix the unit tests here, which so far don't work

@dxL1nus
Copy link
Copy Markdown
Contributor Author

dxL1nus commented May 4, 2026

Plus it is a draft still, because I need to fix the unit tests here, which so far don't work

So far I fixed nearly every unit test apart from two, as I am not quite sure how to fix them yet (I will look into it further).

I will definitely also need to add some new unit tests as well.

dxL1nus added a commit to dxL1nus/ojs-codecheck that referenced this pull request May 4, 2026
@dxL1nus dxL1nus force-pushed the feature/reserve-identifier-with-new-issue-url branch from 17ba4e2 to 5682e8f Compare June 7, 2026 17:36
@dxL1nus
Copy link
Copy Markdown
Contributor Author

dxL1nus commented Jun 7, 2026

This branch now got fully rebased and is ready for review.

!!!! Though a merge should only happen after #108 !!!!

@nuest

@dxL1nus dxL1nus marked this pull request as ready for review June 7, 2026 17:37
dxL1nus added a commit to dxL1nus/ojs-codecheck that referenced this pull request Jun 8, 2026
dxL1nus added a commit to dxL1nus/ojs-codecheck that referenced this pull request Jun 8, 2026
dxL1nus added 19 commits June 8, 2026 17:49
…ved automatically, then issue will be automatically linked as well
…rl exists and Input has some characters inputted
@dxL1nus dxL1nus force-pushed the feature/reserve-identifier-with-new-issue-url branch from a841efd to c89a145 Compare June 8, 2026 16:34
@dxL1nus
Copy link
Copy Markdown
Contributor Author

dxL1nus commented Jun 8, 2026

@nuest you may now review this PR, as every test works again and the rebase to the current version of main is also done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment