fix(reminder-hooks): preserve suppression state across compaction

[Disaster-Terminator]

Summary

• Preserve reminder state across session compaction.
• Prevent reminder hooks from re-arming repeatedly in long sessions.

Changes

• Stop clearing agent-usage-reminder state on session.compacted.
• Stop clearing category-skill-reminder state on session.compacted.
• Cap agent-usage-reminder output per session and keep session.deleted reset behavior.
• Add regression coverage for compaction and delete/reset behavior.

Testing

bun test src/hooks/agent-usage-reminder/index.test.ts src/hooks/category-skill-reminder/index.test.ts

Related Issues

[github-actions]

All contributors have signed the CLA. Thank you! ✅
_{Posted by the CLA Assistant Lite bot.}

[Disaster-Terminator]

I have read the CLA Document and I hereby sign the CLA

[cubic-dev-ai]

1 issue found across 4 files

Confidence score: 5/5

• This PR looks low risk to merge: the only finding is low severity (3/10) and is limited to test quality rather than production behavior.
• The issue in src/hooks/agent-usage-reminder/index.test.ts is that the delete regression test is non-diagnostic, so it may not reliably prove session.deleted clears reminder state.
• Pay close attention to src/hooks/agent-usage-reminder/index.test.ts - strengthen the reset-path assertion (or hit the reminder cap before delete) so the regression check is definitive.

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/hooks/agent-usage-reminder/index.test.ts">

<violation number="1" location="src/hooks/agent-usage-reminder/index.test.ts:65">
P3: This delete regression test is non-diagnostic: one prior reminder is not enough to prove `session.deleted` cleared state. Assert the reset path directly (or drive the session to the reminder cap before deleting) so the test fails on a broken delete handler.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

0 issues found across 1 file (changes from recent commits).

_{Auto-approved: Correctly prevents reminder loops by preserving suppression state across compaction and introduces a sensible reminder cap with thorough test coverage.}