fix(ralph-loop): ensure new session starts on /ralph-loop invocation (fixes #1900)#3430
Closed
MoerAI wants to merge 2 commits intocode-yeongyu:devfrom
Closed
fix(ralph-loop): ensure new session starts on /ralph-loop invocation (fixes #1900)#3430MoerAI wants to merge 2 commits intocode-yeongyu:devfrom
MoerAI wants to merge 2 commits intocode-yeongyu:devfrom
Conversation
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
No issues found across 6 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Targeted fixes for #1900 and #3133 with new regression tests. Logic changes for defaulting to 'reset' and config file discovery are safe and improve reliability.
Contributor
Author
|
Closing — PR has been open 14+ days with zero maintainer engagement. Happy to reopen or rework if this fix is still wanted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/ralph-loopto the reset strategy so each iteration starts in a fresh sessionProblem
/ralph-loopwas still falling back to thecontinuestrategy when no explicit strategy was set. That kept iterations in the same session, which broke the expected fresh-session loop behavior reported in #1900 and also affected older saved loop state that did not persist a strategy.Fix
The ralph-loop config schema and runtime fallbacks now default to
reset, so a plain/ralph-loopinvocation creates a new iteration session by default. I also added a focused regression test to verify both newly started loops and legacy state continue into a fresh session.Changes
src/config/schema/ralph-loop.tscontinuetoresetsrc/hooks/ralph-loop/loop-state-controller.tsresetwhen no strategy is providedsrc/hooks/ralph-loop/iteration-continuation.tsresetsrc/hooks/ralph-loop/default-reset-strategy.test.tsFixes #1900
Summary by cubic
Make
/ralph-loopstart a fresh session by default and handle legacy loop state correctly. Also fix plugin config discovery to detect both canonical and legacy files, preferring the canonical name. Fixes #1900 and #3133.resetin schema and runtime; legacy state without a strategy is treated asresetso each iteration spawns a new session; added a focused regression test.getOpenCodeConfigPathsnow usesdetectPluginConfigFileto findoh-my-openagent.json(canonical) oroh-my-opencode.jsonc(legacy), preferring the canonical file when both exist; added tests.Written for commit cf5c2e3. Summary will update on new commits.