Fix primary agent model precedence#3428
Open
afafara wants to merge 1 commit intocode-yeongyu:devfrom
Open
Conversation
Contributor
|
All contributors have signed the CLA. Thank you! ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
There was a problem hiding this comment.
No issues found across 3 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Requires human review: This PR deliberately flips model precedence logic, which is a functional change that alters existing behavior and breaks previous test expectations.
|
I have read the CLA Document and I hereby sign the CLA |
This was referenced Apr 17, 2026
github-actions Bot
added a commit
to Vacbo/oh-my-opencode
that referenced
this pull request
Apr 19, 2026
4 tasks
github-actions Bot
added a commit
to Vacbo/oh-my-opencode
that referenced
this pull request
Apr 19, 2026
3 tasks
github-actions Bot
added a commit
to Vacbo/oh-my-opencode
that referenced
this pull request
Apr 19, 2026
3 tasks
github-actions Bot
added a commit
to Vacbo/oh-my-opencode
that referenced
this pull request
Apr 19, 2026
2 tasks
github-actions Bot
added a commit
to Vacbo/oh-my-opencode
that referenced
this pull request
Apr 19, 2026
3 tasks
github-actions Bot
added a commit
to Vacbo/oh-my-opencode
that referenced
this pull request
Apr 20, 2026
3 tasks
github-actions Bot
added a commit
to Vacbo/oh-my-opencode
that referenced
this pull request
Apr 20, 2026
3 tasks
github-actions Bot
added a commit
to Vacbo/oh-my-opencode
that referenced
this pull request
Apr 20, 2026
3 tasks
github-actions Bot
added a commit
to Vacbo/oh-my-opencode
that referenced
this pull request
Apr 20, 2026
3 tasks
github-actions Bot
added a commit
to Vacbo/oh-my-opencode
that referenced
this pull request
Apr 20, 2026
github-actions Bot
added a commit
to Vacbo/oh-my-opencode
that referenced
this pull request
Apr 21, 2026
3 tasks
github-actions Bot
added a commit
to Vacbo/oh-my-opencode
that referenced
this pull request
Apr 21, 2026
3 tasks
github-actions Bot
added a commit
to Vacbo/oh-my-opencode
that referenced
this pull request
Apr 21, 2026
3 tasks
github-actions Bot
added a commit
to Vacbo/oh-my-opencode
that referenced
this pull request
Apr 21, 2026
4 tasks
github-actions Bot
added a commit
to Vacbo/oh-my-opencode
that referenced
this pull request
Apr 21, 2026
3 tasks
github-actions Bot
added a commit
to Vacbo/oh-my-opencode
that referenced
this pull request
Apr 21, 2026
3 tasks
github-actions Bot
added a commit
to Vacbo/oh-my-opencode
that referenced
this pull request
Apr 21, 2026
This was referenced Apr 21, 2026
github-actions Bot
added a commit
to Vacbo/oh-my-opencode
that referenced
this pull request
Apr 21, 2026
github-actions Bot
added a commit
to Vacbo/oh-my-opencode
that referenced
this pull request
Apr 21, 2026
4 tasks
github-actions Bot
added a commit
to Vacbo/oh-my-opencode
that referenced
this pull request
Apr 21, 2026
4 tasks
github-actions Bot
added a commit
to Vacbo/oh-my-opencode
that referenced
this pull request
Apr 21, 2026
4 tasks
github-actions Bot
added a commit
to Vacbo/oh-my-opencode
that referenced
this pull request
Apr 21, 2026
3 tasks
github-actions Bot
added a commit
to Vacbo/oh-my-opencode
that referenced
this pull request
Apr 21, 2026
4 tasks
github-actions Bot
added a commit
to Vacbo/oh-my-opencode
that referenced
this pull request
Apr 22, 2026
3 tasks
github-actions Bot
added a commit
to Vacbo/oh-my-opencode
that referenced
this pull request
Apr 22, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/agents/utils.test.tsTesting
Summary by cubic
Fix model precedence for primary agents so the UI-selected model always wins over agent and category overrides. Atlas and Sisyphus now keep the runtime-selected model and restore the resolved variant when applicable.
uiSelectedModelforatlasandsisyphuseven when overrides specify a model or category.Written for commit d62cdfe. Summary will update on new commits.