fix(resolver): drop in-memory resolution cache#1151
Merged
Conversation
The process-lifetime cache in ResolverController could return a stale on-chain address for a phone/user id. That wrong PublicKey flows into directTransfer's timelock derivation, producing a destination vault the server rejects with "payments to external destinations must be withdrawals" — breaking in-chat contact DM sends. Always resolve fresh against the repository. The cache was only ever a round-trip optimization with no correctness benefit; removing it restores the reliable pre-refactor behavior.
github-actions
Bot
added
type: fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Sending money inside a chat via a contact DM fails with the server error:
This regressed at the delegate refactor (#1130), whose only behavioral change (the rest was pure code-moving) was adding a process-lifetime in-memory cache to
ResolverController.Root cause
The cache could hand back a stale/incorrect on-chain
PublicKeyfor a phone number or user id. That address flows intoTransactionController.directTransfer→TimelockDerivedAccounts.newInstance(owner = destinationOwner, token), deriving the wrong destination vault. The server sees a vault it doesn't manage and rejects the transfer as an external destination that must be a withdrawal.This matches the observed device/version signal — fine on an S25 at an earlier build, broken on a Pixel 10 emulator at the next — since a caching bug surfaces per-process/session rather than uniformly.
Fix
Always resolve fresh against the repository. The cache was only ever a network round-trip optimization with no correctness benefit, so removing it restores the reliable pre-refactor behavior. Public API is unchanged; nothing else depended on the cache.