fix(tips): source the minimum tip from the dedicated preset, not the lowest tier#1147
Merged
Conversation
…lowest tier Resolve the server tip presets once into a ResolvedPresets (minimum + low/medium/high tiers) shared by tipPresets and minTipAmount so they stay consistent. minTipAmount now uses the presets' dedicated `minimum` field rather than the lowest tier, which typically sits above it. The built-in fallback gains a $1 minimum below its $5/$10/$20 tiers.
github-actions
Bot
added
area: payments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The "minimum tip" surfaced by the amount entry was derived from the lowest preset tier (
low) viatipPresets.minOrNull(). The server tip presets carry a dedicatedminimumfield that is distinct from — and typically below — thelowtier. This PR sourcesminTipAmountfrom that dedicated field.Changes
ResolvedPresets(minimum, tiers), shared by bothtipPresets(the low/medium/high chips) andminTipAmountso the two stay consistent.minTipAmountnow reads the presets' dedicatedminimumrather than the lowest tier.$1default minimum below its$5 / $10 / $20tiers; USD-localization is folded into a shared helper.Tests
Added coverage to
TipPaymentDelegateTest(all 7 pass):minTipAmountis the dedicatedminimum(1.0), not the lowest tier (2.0)tipPresetsare the low/medium/high tiers only, excluding the minimum$1minimum +$5/$10/$20tiers when the server provides no presets