Fix reschedule issue with same callback#3478
Open
Dimon4eg wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
Please don't merge yet. I'll sync it with PR for cocos2d-x |
|
@Dimon4eg , could this PR be ready for merge now? |
Contributor
Author
|
Done. Also added test for this issue in cocos2d-x repo. |
|
@dumganhar any question about the issue? |
Contributor
Author
|
@dumganhar any update? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue:
cc.director.getScheduler().schedule(callback, target, interval, repeat, delay, paused, key);
Reason:
When we reschedule timer again from callback the scheduler just updates interval value:
timer._interval = interval;After callback executed timer will be canceled:
Fix:
Scheduler will update interval only for not exhausted timers (still running).
In our case, it will create new internal timer object and old one will be canceled after callback.