run_container try out#2442
Draft
jelly wants to merge 4 commits into
Draft
Conversation
jelly
force-pushed
the
admin-s-reduction
branch
from
e79bb75 to
166fc51
Compare
Member
Author
|
The commit message needs to be expanded with some more reasoning and more moved to |
Refactor the invocations to use self.execute where possible, in the future we want to stop using `SSHConnection` as an API.
The test needs a container to be run with some output, this is fast enough to not require backgrounding.
Checkpoint restore is only supported on privileged containers, so avoid `self.execute`.
jelly
force-pushed
the
admin-s-reduction
branch
from
166fc51 to
96d673b
Compare
Introduce a new helper for running containers in the background for tests without requiring the existing `admin_s` session.
jelly
force-pushed
the
admin-s-reduction
branch
from
96d673b to
20f7276
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.