Add create pod validation for name/port mapping#1482
Merged
martinpitt merged 1 commit intoNov 13, 2023
Conversation
Recently the Image Create modal implemented validation for Volume/Port mapping. Re-use the same changes in Podman except for Volumes as there can be some improvements done there.
cockpituous
reviewed
Nov 10, 2023
| const dynamicListOnValidationChange = (value, key) => { | ||
| setValidationFailed(prevState => { | ||
| prevState[key] = value; | ||
| if (prevState[key].every(a => a === undefined)) |
Contributor
There was a problem hiding this comment.
This added line is not executed by any test. Details
| const podNameValidation = validatePodName(podName); | ||
|
|
||
| if (podNameValidation) | ||
| newValidationFailed.containerName = podNameValidation; |
Contributor
There was a problem hiding this comment.
This added line is not executed by any test. Details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently the Image Create modal implemented validation for Volume/Port mapping. Re-use the same changes in Podman except for Volumes as there can be some improvements done there.
I'm happy to integrate the volume validation after #1481