Add clj-kondo macro metadata build option#106
Merged
cnuernber merged 4 commits intocnuernber:masterfrom Sep 9, 2024
Merged
Conversation
Created a helper function that is going to detect if macro contains clj-kondo metadata. If clj-kondo metadata map exists and macro is being built then add metadata map to the built macro with coresponding clj-kondo metadata.
Contributor
Author
|
Hey @cnuernber , |
Owner
|
Definitely - Thanks - it will take me a bit to review this but it looks good to me at first glance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
tablecloth/let-datasetmacro in this PR, I noticed thatwrite-api!doesn't build macro metadata at all.Reason
Usually developers write their own set of rules regarding how clj-kondo is going to behave but I believe that should be the case only for macros that are
internallyused.I was thinking that it would be beneficial if we could provide build option for linting metadata when macro is built using
write-api!.Solution
clj-kondonamespace part.Why I chose this approach
My goal is to learn and contribute to open source as much as possible.