-
Notifications
You must be signed in to change notification settings - Fork 29
Flatcar docs analysis - writing and updates #349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
a39f7d7
29dcc38
3d18440
d15b315
4ddc964
0e0c0d4
e1397f1
5a280f9
ea3562e
955347e
62b8456
2e5f52b
0e26f2c
d383d34
228768c
97a0e68
25f0822
915a866
b4bd4fd
ca4bf44
cb9ba3a
845342d
5979b0b
253d704
5053a27
dc4388e
c98bc86
ec18eaf
ef847b4
e2513b1
835fadf
acb085d
675eea0
03f3ee6
76118c5
4f54a15
542ba6f
0354429
916cacf
3bce5a2
f15ee31
5ff92c6
ec95c52
c3638b1
81ad304
2a8fc09
0e0247a
b7ed247
a44d83f
6ebd559
30c874c
d35caa0
14e309a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -272,29 +272,30 @@ specifically for them. We evaluate on the following: | |||||
|
|
||||||
| - **Is “getting started” or similar clearly labeled?** | ||||||
|
|
||||||
| The "Learning Series" is a well-documented getting started guide. There is a | ||||||
| Heading 3 heading "Getting started" in the overview. | ||||||
| The "Learning Series" is a well-documented getting started guide. There is a | ||||||
| Heading 3 heading "Getting started" in the overview. | ||||||
|
|
||||||
| - **Is installation documented step-by-step?** | ||||||
|
|
||||||
| Procedures are not formal step-by-steps, but rather sufficient descriptions of | ||||||
| the purpose and result of running the provided code example. | ||||||
| Procedures are not formal step-by-steps, but rather sufficient descriptions of | ||||||
| the purpose and result of running the provided code example. | ||||||
|
|
||||||
| Even if the new user does not know anything about the technologies, the guidance | ||||||
| still works but would be helped greatly with numbered steps. | ||||||
| Even if the new user does not know anything about the technologies, the | ||||||
| guidance still works but would be helped greatly with numbered steps. | ||||||
|
|
||||||
| - **If needed, are multiple OSes documented?** | ||||||
|
|
||||||
| Users are typically running a Linux machine, or a Virtual Machine running on | ||||||
| Windows or macOS. It would be beneficial to acquaint the user with any specific | ||||||
| client guidance, particularly when installing tools and images. For example, | ||||||
| brew may not install all components one gets from directly installing binaries. | ||||||
| Users are typically running a Linux machine, or a Virtual Machine running on | ||||||
| Windows or macOS. It would be beneficial to acquaint the user with any | ||||||
| specific client guidance, particularly when installing tools and images. For | ||||||
| example, brew may not install all components one gets from directly installing | ||||||
| binaries. | ||||||
|
|
||||||
| - **Do users know where to go after reading the getting started guide?** | ||||||
|
|
||||||
| Intuitively perhaps, as the Learning Services provides sufficient content to get | ||||||
| Flatcar instances running. It would be good to have listings of next steps for | ||||||
| the various deployment scenarios. | ||||||
| Intuitively perhaps, as the Learning Services provides sufficient content to | ||||||
| get Flatcar instances running. It would be good to have listings of next steps | ||||||
| for the various deployment scenarios. | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "Intuitively perhaps, ..." "... the Learning Services [section?] provides sufficient content ..." "It would be good ..."
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. s/b Learning Series section |
||||||
|
|
||||||
| - **Is your new user content clearly signposted on your site’s homepage or at | ||||||
| the top of your information architecture?** | ||||||
|
|
@@ -304,8 +305,8 @@ Other than being a top level node in the table of contents, no. | |||||
| - **Is there sample code or other example content that can easily be | ||||||
| copy-pasted?** | ||||||
|
|
||||||
| Yes, most pages have code samples, but currently the UI does not show code | ||||||
| example blocks with copy buttons. The code is simply in a different font. | ||||||
| Yes, most pages have code samples, but currently the UI does not show code | ||||||
| example blocks with copy buttons. The code is simply in a different font. | ||||||
|
|
||||||
| ##### Content maintainability & site mechanics | ||||||
|
|
||||||
|
|
@@ -316,16 +317,16 @@ We evaluate on the following: | |||||
|
|
||||||
| - **Is your documentation searchable?** | ||||||
|
|
||||||
| Yes, the home page has a search bar where any results populate a dropdown for | ||||||
| selection. | ||||||
| Yes, the home page has a search bar where any results populate a dropdown for | ||||||
| selection. | ||||||
|
|
||||||
| - **Are you planning for localization/internationalization?** | ||||||
|
|
||||||
| There are currently no plans for localization. | ||||||
| There are currently no plans for localization. | ||||||
|
|
||||||
| - **Do you have a clearly documented method for versioning your content?** | ||||||
|
|
||||||
| Being an incubating project, the content is not versioned at this time. | ||||||
| Being an incubating project, the content is not versioned at this time. | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
|
||||||
| ##### Content creation processes | ||||||
|
|
||||||
|
|
@@ -337,21 +338,21 @@ We evaluate on the following: | |||||
| - **Is there a clearly documented (ongoing) contribution process for | ||||||
| documentation?** | ||||||
|
|
||||||
| Yes. There is a 'How to contribute' node with guidance for using the GitHub | ||||||
| repository, formatting, and style. | ||||||
| Yes. There is a 'How to contribute' node with guidance for using the GitHub | ||||||
| repository, formatting, and style. | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "Node"? Is this a file in the doc repo?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. changed to section |
||||||
|
|
||||||
| - **Does your code release process account for documentation creation & | ||||||
| updates?** | ||||||
|
|
||||||
| The team regularly updates content as the project is incubating. | ||||||
| The team regularly updates content as the project is incubating. | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's good, but it's not a process. If there is no formal process, say so. |
||||||
|
|
||||||
| - **Who reviews and approves documentation pull requests?** | ||||||
|
|
||||||
| Maintainers delegate doc approval to experienced code contributors. | ||||||
| Maintainers delegate doc approval to experienced code contributors. | ||||||
|
|
||||||
| - **Does the website have a clear owner/maintainer?** | ||||||
|
|
||||||
| Yes. | ||||||
| Yes. | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's helpful to say where this is documented. I usually find it in a "contributors-and-maintainers" file or some such. |
||||||
|
|
||||||
| ##### Inclusive language | ||||||
|
|
||||||
|
|
@@ -368,9 +369,9 @@ those only "abort" would necessitate a fix on eight occurrences. | |||||
|
|
||||||
| - **Does the project use language like "simple", "easy", etc.?** | ||||||
|
|
||||||
| Yes, there are about 53 hits of "easy" to replace. The word "simple" is used, | ||||||
| but the context is a simpler piece of code or process rather than a task being | ||||||
| simple. | ||||||
| Yes, there are about 53 hits of "easy" to replace. The word "simple" is used, | ||||||
| but the context is a simpler piece of code or process rather than a task being | ||||||
| simple. | ||||||
|
|
||||||
| ### Recommendations | ||||||
|
|
||||||
|
|
@@ -460,47 +461,71 @@ be developing professional-quality documentation alongside the project code. | |||||
|
|
||||||
| | Criterion | [Rating (1-5)] | | ||||||
| | ----------------------------------------- | -------------- | | ||||||
| | Communication methods documented | [rating (1-5)] | | ||||||
| | Beginner friendly issue backlog | [rating (1-5)] | | ||||||
| | “New contributor” getting started content | [rating (1-5)] | | ||||||
| | Project governance documentation | [rating (1-5)] | | ||||||
| | Communication methods documented | 3 | | ||||||
| | Beginner friendly issue backlog | 3 | | ||||||
| | “New contributor” getting started content | 3 | | ||||||
| | Project governance documentation | 3 | | ||||||
|
|
||||||
| ### Comments | ||||||
|
|
||||||
| > AUTHOR NOTE: make any overall comments about the Contributor Documentation | ||||||
| > here. | ||||||
|
|
||||||
| The following sections contain brief assessments of each element of the | ||||||
| Contributor Documentation rubric. | ||||||
|
|
||||||
| > AUTHOR NOTE: For each heading below, discuss how well the in-scope items meet | ||||||
| > these criteria. Keep in mind that much of the contributor documentation might | ||||||
| > be contained in the documentation repository. (Criteria are copied from | ||||||
| > criteria.md) | ||||||
|
|
||||||
| #### Communication methods documented | ||||||
|
|
||||||
| One of the easiest ways to attract new contributors is making sure they know how | ||||||
| to reach you. | ||||||
|
|
||||||
| We evaluate on the following: | ||||||
|
|
||||||
| - Is there a Slack/Discord/Discourse/etc. community and is it prominently linked | ||||||
| from your website? | ||||||
| - Is there a direct link to your GitHub organization/repository? | ||||||
| - Are weekly/monthly project meetings documented? Is it clear how someone can | ||||||
| join those meetings? | ||||||
| - **Is there a Slack or similar resource and is it linked from your website?** | ||||||
|
|
||||||
| Yes, however these chat and social media links are on the README file of the | ||||||
| [Flatcar GitHub repository](https://github.com/flatcar/Flatcar). | ||||||
|
|
||||||
| Chats: | ||||||
| - Matrix: https://app.element.io/#/room/#flatcar:matrix.org | ||||||
| - Slack: https://kubernetes.slack.com/archives/C03GQ8B5XNJ Social media: | ||||||
| - Mastodon: https://hachyderm.io/@flatcar | ||||||
| - X: https://x.com/flatcar | ||||||
|
|
||||||
| - **Is there a direct link to your GitHub organization/repository?** | ||||||
|
|
||||||
| Not from the website. | ||||||
|
|
||||||
| - **Are weekly/monthly project meetings documented? Is it clear how someone can | ||||||
| join those meetings?** | ||||||
|
|
||||||
| Yes. Project planning, meetings, and discussions are available on the GitHub | ||||||
| repository: https://github.com/flatcar/Flatcar/discussions and | ||||||
| https://github.com/flatcar/Flatcar/discussions/2025. | ||||||
|
|
||||||
| - Are mailing lists documented? | ||||||
|
|
||||||
| #### Beginner-friendly issue backlog | ||||||
|
|
||||||
| We evaluate on the following: | ||||||
|
|
||||||
| - Are docs issues well-triaged? | ||||||
| - Is there a clearly marked way for new contributors to make code or | ||||||
| documentation contributions (i.e. a “good first issue” label)? | ||||||
| - Are issues well-documented (i.e., more than just a title)? | ||||||
| - Are issues maintained for staleness? | ||||||
| - **Are docs issues well-triaged?** | ||||||
|
|
||||||
| Yes, this URL shows doc issues being tracked in GitHub: | ||||||
| https://github.com/flatcar/Flatcar/issues?q=state%3Aopen%20label%3Akind%2Fdocs | ||||||
|
|
||||||
| - **Is there a clearly marked way for new contributors to make code or | ||||||
| documentation contributions (i.e. a “good first issue” label)?** | ||||||
|
|
||||||
| Each page has these two links at the bottom: | ||||||
| - An `Edit this page` link opens the page for editing in GitHub if a fork | ||||||
| exists, otherwise shows the option to fork the repository. | ||||||
| - A `File documentation issue` link opens a new GitHub issue. | ||||||
|
|
||||||
| - **Are issues well-documented (i.e., more than just a title)?** | ||||||
|
|
||||||
| Yes, most issues are thoroughly described with detailed proposed solutions. | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there a policy or guidelines for documenting issues? What do you mean by "most" issues? What are the exceptions?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added a link the Finding Issues section of the Contributing Guide. |
||||||
|
|
||||||
| - **Are issues maintained for staleness?** | ||||||
|
|
||||||
| Generally, yes. | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why "generally"?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed |
||||||
|
|
||||||
| #### New contributor getting started content | ||||||
|
|
||||||
|
|
@@ -510,9 +535,26 @@ in easily? | |||||
|
|
||||||
| We evaluate on the following: | ||||||
|
|
||||||
| - Do you have a community repository or section on your website? | ||||||
| - Is there a document specifically for new contributors/your first contribution? | ||||||
| - Do new users know where to get help? | ||||||
| - **Do you have a community repository or section on your website?** | ||||||
|
|
||||||
| Not currently. | ||||||
|
|
||||||
| - **Is there a document specifically for new contributors/your first | ||||||
| contribution?** | ||||||
|
|
||||||
| Yes. There is a "How to contribute" node at the bottom of the navigation tree, | ||||||
| and contains guidance on making pull requests in the Flatcar GitHub | ||||||
| repository. Also included is guidance style and formatting with links to style | ||||||
| guides. | ||||||
|
|
||||||
| https://www.flatcar.org/docs/latest/contribute/ | ||||||
|
|
||||||
| - **Do new users know where to get help?** | ||||||
|
|
||||||
| That would be Flatcar's Slack and Matrix chat channels. That information is | ||||||
| available in the README for Flatcar's GitHub repository: | ||||||
|
|
||||||
| https://github.com/flatcar/Flatcar?tab=readme-ov-file | ||||||
|
|
||||||
| #### Project governance documentation | ||||||
|
|
||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason these paragraphs are sometimes indented?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They should be indented if inside a bulleted list, but I wasn't being consistent.