Repository navigation
proxy: multiple credentials per user (aliases), streaming SigV4 re-signing - #290
Open
kwinston-dev wants to merge 4 commits into
Open
kwinston-dev wants to merge 4 commits into
kwinston-dev wants to merge 4 commits into
Conversation
Signed-off-by: Artem Torubarov <torubarov.a.a@gmail.com>
Signed-off-by: Artem Torubarov <torubarov.a.a@gmail.com>
- read pre-alias flat proxy credentials (user: {accessKeyID, secretAccessKey})
as the alias named after the user, so existing proxy configs keep working
- proxy reads dynamic per-user S3 credentials (set without --alias) as the
alias named after the user; explicit alias entries take precedence
- e2e test on MinIO: a second storage user with access to a migrating bucket
writes through the proxy; its writes are captured as replication events
during and after the initial migration
Signed-off-by: Ualikhan <yalikhan752@gmail.com>
Uploads signed with STREAMING-AWS4-HMAC-SHA256-PAYLOAD(-TRAILER) (minio-go over plain http, some SDKs) were rejected by real backends: the proxy re-signs the seed request with the storage credentials, but the per-chunk signatures in the aws-chunked body were still chained from the client's seed signature and secret. The auth middleware now verifies every chunk (and signed trailer) signature against the client key before releasing its data, and the forwarding client replaces them with signatures chained from its own seed signature. Signatures have a fixed length, so the framing and Content-Length are unchanged and signed trailers (checksums) reach the storage. Drops the test pinning the limitation and the DisableContentSha256 workarounds in test/minio. Signed-off-by: Ualikhan <yalikhan752@gmail.com>
kwinston-dev
requested review from
aiivashchenko,
arttor,
fa-at-pulsit and
schucly
as code owners
November 12, 2026 11:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes #237, closes #231. Proxy credentials are now
user -> alias -> credential: any alias key authenticates as the user, so writes by other S3 users to a migrating bucket get replicated. The old flat format and dynamic creds without--aliasstill work (read as the alias named after the user).Also fixes streaming SigV4 (aws-chunked) uploads through the proxy: chunk signatures are verified and re-signed for the storage.
Tests: MinIO e2e with a second user writing during migration, streaming PUT/UploadPart e2e, config and creds unit tests.