Upgrade to Terraform 0.12 - #10
Closed
Josh Myers (joshmyers) wants to merge 1 commit into
Closed
Conversation
Run `terraform 0.12upgrade` against codebase. Note that due to Terraform 0.12 now using sets, we call `tolist` to workaround [1] [1] hashicorp/terraform-provider-aws#7522
|
|
||
| variable "parameter_write" { | ||
| type = "list" | ||
| type = list(string) |
There was a problem hiding this comment.
shouldn't this be a list(map(string))?
There was a problem hiding this comment.
yep I agree - after upgrading this mod to 0.12 and changing var "parameter_write" to type list(map(string)) this module works like a charm so far on 0.12.19
|
poke |
Erik Osterman (Cloud Posse) (osterman)
requested a review
from Andriy Knysh (aknysh)
November 20, 2019 18:15
Contributor
|
Josh Myers (@joshmyers) this one is included in #12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
Run
terraform 0.12upgradeagainst codebase. Note that due to Terraform0.12 now using sets, we call
tolistto workaround [1][1] hashicorp/terraform-provider-aws#7522
testing
I have tested this using Terraform 0.12.6