refactor(careinstruction): use lifecycle.Reconcile - #78
Open
jellonek wants to merge 1 commit into
Open
Conversation
jellonek
commented
Aug 21, 2026
jellonek
commented
Contributor
- related issue [FEAT shoot-grafter] - Refactor reconciler logic #70
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the CareInstruction controller reconcile flow to use the shared greenhouse/pkg/lifecycle reconciliation pattern (issue #70), splitting create/update vs. delete handling and adding the object-level hooks needed for lifecycle-managed status/conditions.
Changes:
- Replace the controller’s monolithic
Reconcileimplementation withlifecycle.Reconcileand lifecycle hook methods (EnsureCreated,EnsureDeleted,EnsureSuspended). - Add condition/suspension helper methods on
CareInstructionto satisfy lifecycle expectations.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| controller/careinstruction/careinstruction_controller.go | Switch reconcile entrypoint to lifecycle.Reconcile; introduce lifecycle hook methods for create/update/delete/suspend handling. |
| api/v1alpha1/careinstruction_types.go | Add lifecycle-facing condition/suspension methods on the CareInstruction API type. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jellonek
force-pushed
the
refactor-careinstruction-reconcile
branch
5 times, most recently
from
August 21, 2026 14:38
4b1fd77 to
b0a39bf
Compare
- related issue #70 Signed-off-by: Piotr Skamruk <piotr.skamruk@gmail.com>
jellonek
force-pushed
the
refactor-careinstruction-reconcile
branch
from
August 21, 2026 14:49
b0a39bf to
a5c4fc4
Compare
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.