remove .localhost from petclinic example#520
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the shipped example configurations to remove the .localhost suffix from the Petclinic baseDomain, affecting how Petclinic ingress hostnames are generated in the provided example profiles and a dev helper script.
Changes:
- Changed
content.variables.petclinic.baseDomainfrompetclinic.localhosttopetclinicin multiple example config YAMLs. - Updated the generated local config snippet in
scripts/dev/prepare_two_registries.shto use the same new PetclinicbaseDomain.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/resources/application-single-namespace-example.yaml | Updates Petclinic baseDomain in the single-namespace example profile. |
| src/main/resources/application-operator-full.yaml | Updates Petclinic baseDomain in the operator full example profile. |
| src/main/resources/application-operator-content-examples.yaml | Updates Petclinic baseDomain in the operator content-examples profile. |
| src/main/resources/application-full.yaml | Updates Petclinic baseDomain in the full example profile. |
| src/main/resources/application-full-prefix.yaml | Updates Petclinic baseDomain in the prefixed full example profile. |
| src/main/resources/application-content-examples.yaml | Updates Petclinic baseDomain in the content-examples profile. |
| scripts/dev/prepare_two_registries.sh | Updates the generated local config used for the “two registries” dev scenario. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
This PR updates the shipped example configurations to remove the
.localhostsuffix from the PetclinicbaseDomain, affecting how Petclinic ingress hostnames are generated in the provided example profiles and a dev helper script.Changes:
content.variables.petclinic.baseDomainfrompetclinic.localhosttopetclinicin multiple example config YAMLs.scripts/dev/prepare_two_registries.shto use the same new PetclinicbaseDomain.