Skip to content

Add @mvach to cnbapplifecycle approvers#1472

Merged
ameowlia merged 1 commit into
cloudfoundry:mainfrom
sap-contributions:add-mvach-cnbapplifecycle
Apr 17, 2026
Merged

Add @mvach to cnbapplifecycle approvers#1472
ameowlia merged 1 commit into
cloudfoundry:mainfrom
sap-contributions:add-mvach-cnbapplifecycle

Conversation

@pbusko
Copy link
Copy Markdown
Contributor

@pbusko pbusko commented Apr 8, 2026

in addition to the existing approver rights in the https://github.com/cloudfoundry/kind-deployment

@beyhan
Copy link
Copy Markdown
Member

beyhan commented Apr 8, 2026

Hi,

Just to clarify, if I understand correctly, you're looking for a faster promotion pathway. What is the reason for that? In general, the requirements for approvers are defined in our roles.md, and we have a script available for generating contributions.

@beyhan beyhan added the wg-arp label Apr 8, 2026
@beyhan beyhan requested a review from ameowlia April 8, 2026 11:33
@modulo11
Copy link
Copy Markdown
Contributor

Hi,

Just to clarify, if I understand correctly, you're looking for a faster promotion pathway. What is the reason for that? In general, the requirements for approvers are defined in our roles.md, and we have a script available for generating contributions.

@beyhan not really, b/c @mvach is part of our team and we just missed adding him initially. Granting permissions would be great to continue our work.

@beyhan
Copy link
Copy Markdown
Member

beyhan commented Apr 17, 2026

I see. Then we have all the context in place and we have two approver approvals with @pbusko opening the pr and @c0d1ngm0nk3y approving it. So, @ameowlia could decide on this as WG lead.

@ameowlia ameowlia merged commit 4e1165d into cloudfoundry:main Apr 17, 2026
2 checks passed
@github-project-automation github-project-automation Bot moved this from Inbox to Done in CF Community Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants