Skip to content

CI: Allow ops files for BRATS dns#2735

Merged
selzoc merged 1 commit into
mainfrom
enable-brats-dns-ops-files
May 14, 2026
Merged

CI: Allow ops files for BRATS dns#2735
selzoc merged 1 commit into
mainfrom
enable-brats-dns-ops-files

Conversation

@selzoc
Copy link
Copy Markdown
Member

@selzoc selzoc commented May 14, 2026

This will allow the bosh-dns pipeline to pass in some jammy-specific overrides (most of BRATs is hardcoded for noble).

This will allow the bosh-dns pipeline to pass in some jammy-specific
overrides (most of BRATs is hardcoded for noble).

ai-assisted=yes
[TNZ-88995]
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 14, 2026

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 9a9eaef1-caba-4b28-896e-a8dc60170e63

📥 Commits

Reviewing files that changed from the base of the PR and between 5afc2fd and 963545a.

📒 Files selected for processing (1)
  • ci/shared/brats/test-acceptance.sh

Walkthrough

This PR adds conditional DNS manifest modification to the BRATs acceptance test script. When the BRATS_DNS_MANIFEST_OPS_FILES environment variable is set, the script now uses bosh int to apply provided ops files to a template DNS manifest, generates a modified manifest in a temporary location, and copies the result back to the test manifest path. If the environment variable is not set, no DNS manifest modification occurs. The rest of the test flow remains unchanged.

Suggested reviewers

  • mkocher
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch enable-brats-dns-ops-files

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@selzoc selzoc merged commit bdc8b89 into main May 14, 2026
19 of 22 checks passed
@selzoc selzoc deleted the enable-brats-dns-ops-files branch May 14, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants