Skip to content

Instrument LOG_EXCEPTION to observe a new Sentry disposition exception detail - #7185

Open
jtolio wants to merge 1 commit into
jolio/catch-leaked-kfg27xfrom
jolio/instrument-l-lziro4
Open

Instrument LOG_EXCEPTION to observe a new Sentry disposition exception detail#7185
jtolio wants to merge 1 commit into
jolio/catch-leaked-kfg27xfrom
jolio/instrument-l-lziro4

Conversation

@jtolio

@jtolio jtolio commented Aug 29, 2026

Copy link
Copy Markdown
Member

This will allow us to set NOSENTRY or SENTRY_DO or SENTRY_RT or similar on specific messages, designating how we handle these errors or what development team they go to, without adding strings to exception messages.

Also tie wdErrId fields more directly to the appropriate name.

@jtolio
jtolio requested review from a team as code owners August 29, 2026 03:58
Comment thread src/workerd/util/sentry.h Outdated
@ask-bonk

ask-bonk Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

I'm Bonk, and I've done a quick review of your PR.

Adds Sentry disposition details to LOG_EXCEPTION output and tests their logging behavior.

  1. Medium src/workerd/util/sentry.h:55 removes the compile-time-only context guard, allowing dynamic Sentry fingerprints. Posted one inline suggestion.

github run

…n detail

This will allow us to set NOSENTRY or SENTRY_DO or SENTRY_RT or
similar on specific messages, designating how we handle these
errors or what development team they go to, without adding strings
to exception messages.

Also tie wdErrId fields more directly to the appropriate name.
@jtolio
jtolio force-pushed the jolio/instrument-l-lziro4 branch from 7004dd4 to 926896e Compare August 29, 2026 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant