Skip to content

Piping suite: absorb special-buffer pipe writes (audit G9) - #7181

Open
jasnell wants to merge 1 commit into
jasnell/streams-test-consolidation-9from
jasnell/streams-test-consolidation-10
Open

Piping suite: absorb special-buffer pipe writes (audit G9)#7181
jasnell wants to merge 1 commit into
jasnell/streams-test-consolidation-9from
jasnell/streams-test-consolidation-10

Conversation

@jasnell

@jasnell jasnell commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

More streams test consolidations

@jasnell
jasnell requested review from a team as code owners August 28, 2026 23:08
@ask-bonk

ask-bonk Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

src/tests/streams/piping/AGENTS.md:84 duplicates the two regression names already listed on the preceding line, leaving the security-regression inventory inaccurate.

@ask-bonk

ask-bonk Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

I'm Bonk, and I've done a quick review of your PR.

Consolidates special-buffer piping coverage into the shared streams piping suite.

  1. Low: src/tests/streams/piping/AGENTS.md:84 duplicates the security regression names, leaving the suite inventory inaccurate. Posted a suggestion comment.

github run

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 37.01%. Comparing base (40cc902) to head (aaaf8d4).

Additional details and impacted files
@@                           Coverage Diff                            @@
##           jasnell/streams-test-consolidation-9    #7181      +/-   ##
========================================================================
- Coverage                                 37.03%   37.01%   -0.02%     
========================================================================
  Files                                       794      793       -1     
  Lines                                    247909   247822      -87     
  Branches                                  19572    19572              
========================================================================
- Hits                                      91805    91743      -62     
+ Misses                                   145013   144998      -15     
+ Partials                                  11091    11081      -10     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants