Add cache, htmlrewriter, and formdata streams suites - #7178
Conversation
![ask-bonk[bot]](https://avatars.githubusercontent.com/in/2454580?s=60&v=4){kind=small}
| wd_test( | ||
| src = "cache-cpp.wd-test", | ||
| data = cache_suite_srcs, | ||
| ) |
There was a problem hiding this comment.
The moved regression previously ran with only nodejs_compat. This C++ cell forces the standard TransformStream constructor, so the test no longer covers workers before transformstream_enable_standard_constructor became enabled. Add an unflagged legacy config/module that runs concurrentClonePuts, then register it here with its all-compat-flags variant disabled.
| wd_test( | |
| src = "cache-cpp.wd-test", | |
| data = cache_suite_srcs, | |
| ) | |
| wd_test( | |
| src = "cache-cpp.wd-test", | |
| data = cache_suite_srcs, | |
| ) | |
| # Retains the cache clone-put regression for workers using the legacy | |
| # TransformStream constructor. | |
| wd_test( | |
| src = "cache-cpp-legacy.wd-test", | |
| data = cache_suite_srcs, | |
| generate_all_compat_flags_variant = False, | |
| ) |
| .transform(new Response(rs)) | ||
| .text(); | ||
| strictEqual(elements, COUNT); | ||
| strictEqual(result.length, doc.length); |
There was a problem hiding this comment.
This only compares output length, so a corruption that preserves length passes despite the test and its comment claiming byte-exact output.
| strictEqual(result.length, doc.length); | |
| strictEqual(result, doc); |
|
I'm Bonk, and I've done a quick review of your PR. Consolidates cache, FormData, and HTMLRewriter stream tests into new dual-implementation suites.
Posted 2 inline suggestion comments. Here's a joke for you: Why did the stream get promoted? It always went with the flow. |
1 participant
More streams test consolidations