More streams test consolidation and gap filling - #7177
Open
jasnell wants to merge 3 commits into
Open
Conversation
| return new Response(ts10.readable); | ||
| } | ||
|
|
||
| if (url.pathname.startsWith('/pool/')) { |
Contributor
There was a problem hiding this comment.
Promise.all() starts the fetches but does not require their handlers to overlap: these streams were already filled and closed during module evaluation, so serial request handling produces the same response text. Gate the handlers until all four requests have arrived, so a regression that serializes this path cannot pass the test.
Suggested change
| if (url.pathname.startsWith('/pool/')) { | |
| if (url.pathname.startsWith('/pool/')) { | |
| const i = Number(url.pathname.split('/')[2]); | |
| const state = (globalThis.poolRequestBarrier ??= (() => { | |
| let release; | |
| return { | |
| entered: 0, | |
| wait: new Promise((resolve) => { | |
| release = resolve; | |
| }), | |
| release: () => release(), | |
| }; | |
| })()); | |
| if (++state.entered === streamPool.length) state.release(); | |
| await state.wait; | |
| return new Response(streamPool[i]); | |
| } |
Contributor
|
I'm Bonk, and I've done a quick review of your PR. Adds stream transfer/clone, IoContext concurrency, piping, and writable queue-accounting coverage.
Time for a pun! That concurrency test needs a little more stream team. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.