Next large chunk of streams consolidation tests and fixes - #7176
Next large chunk of streams consolidation tests and fixes#7176jasnell wants to merge 28 commits into
Conversation
|
@jasnell Bonk workflow was cancelled. View workflow run · To retry, trigger Bonk again. |
aab0f79 to
f10bfab
Compare
f10bfab to
98fbcaa
Compare
98fbcaa to
7e9ef77
Compare
7e9ef77 to
0ac24d9
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7176 +/- ##
==========================================
+ Coverage 36.33% 37.19% +0.85%
==========================================
Files 811 800 -11
Lines 258167 250695 -7472
Branches 19918 19918
==========================================
- Hits 93813 93236 -577
+ Misses 153052 146139 -6913
- Partials 11302 11320 +18 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
0ac24d9 to
d95893b
Compare
d95893b to
863a100
Compare
…er-cancel, error noop
The iocontext suite's globalScopeTransformStream test is the regression guard: reverting this change makes its module-scope construction segfault iocontext-cpp@ again under the harness's --predictable mode.
863a100 to
ac36c64
Compare
guybedford
left a comment
guybedford
left a comment
There was a problem hiding this comment.
Reviewed the migration end to end: traced every export const from the deleted test files into the new suites, ran all 190 //src/tests/streams/... targets locally against both implementations (plus the touched api/tests targets), and confirmed the iocontext regression guard is real — reverting the transform.c++ change reproduces the segfault in iocontext-cpp@. LGTM.
One minor coverage gap noted inline.
| }; | ||
|
|
||
| // Test that new ReadableStream creates the right kind of controller | ||
| export const newReadableStreamControllerType = { |
There was a problem hiding this comment.
The controller-type assertions from this test (c instanceof ReadableStreamDefaultController / ReadableByteStreamController, byobRequest instanceof ReadableStreamBYOBRequest) and the same-pull caching identity byobRequest === c.byobRequest don't appear to have made it into the new suites — everything else here traced to a semantic equivalent. Worth folding into readable/api-surface.js and readable-byte/controller.js as a follow-up.
|
I'll likely hold off on merging this one until #7213 lands... it has a better fix for the TransformStream issues. |
3 participants
This is the largest chunk, covering transforms, readable, byob, and related. Any remaining chunks after this should be much much smaller.