Skip to content

Preserve VFS exceptions during SQLite open - #7151

Open
jtolio wants to merge 1 commit into
jolio/tag-sqlite-e-3ybjsgfrom
jolio/preserve-vfs-r2y25y
Open

Preserve VFS exceptions during SQLite open#7151
jtolio wants to merge 1 commit into
jolio/tag-sqlite-e-3ybjsgfrom
jolio/preserve-vfs-r2y25y

Conversation

@jtolio

@jtolio jtolio commented Aug 27, 2026

Copy link
Copy Markdown
Member

Capture directory VFS exceptions raised by sqlite3_open_v2() and rethrow the original exception with its stack instead of replacing it with SQLite's generic open error.

@jtolio
jtolio requested review from a team as code owners August 27, 2026 20:21
@ask-bonk

ask-bonk Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

LGTM!

github run

@jtolio
jtolio force-pushed the jolio/preserve-vfs-r2y25y branch from 7901177 to 72111fc Compare August 27, 2026 20:23

@shrima-cf shrima-cf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtolio
jtolio force-pushed the jolio/preserve-vfs-r2y25y branch from 72111fc to 1c734df Compare August 28, 2026 14:11
@codecov-commenter

codecov-commenter commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.19048% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 35.65%. Comparing base (bc9a0fb) to head (874ce3a).

Files with missing lines Patch % Lines
src/workerd/util/sqlite-test.c++ 72.22% 0 Missing and 5 partials ⚠️
Additional details and impacted files
@@                      Coverage Diff                      @@
##           jolio/tag-sqlite-e-3ybjsg    #7151      +/-   ##
=============================================================
- Coverage                      35.65%   35.65%   -0.01%     
=============================================================
  Files                            814      814              
  Lines                         258962   258980      +18     
  Branches                       19578    19581       +3     
=============================================================
+ Hits                           92329    92330       +1     
- Misses                        155572   155583      +11     
- Partials                       11061    11067       +6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jtolio
jtolio force-pushed the jolio/preserve-vfs-r2y25y branch from 1c734df to 2720e61 Compare August 28, 2026 15:34
@jtolio
jtolio force-pushed the jolio/preserve-vfs-r2y25y branch from 2720e61 to 9186470 Compare August 29, 2026 03:57
Capture directory VFS exceptions raised by sqlite3_open_v2()
and rethrow the original exception with its stack instead of
replacing it with SQLite's generic open error.
@jtolio
jtolio force-pushed the jolio/preserve-vfs-r2y25y branch from 9186470 to 874ce3a Compare August 29, 2026 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants