Tag SQLite errors with SENTRY_DO - #7150
Open
jtolio wants to merge 2 commits into
Open
Conversation
jtolio
force-pushed
the
jolio/tag-sqlite-e-3ybjsg
branch
from
August 27, 2026 20:20
2dfa4cf to
cf5f0bf
Compare
Contributor
|
LGTM |
jtolio
force-pushed
the
jolio/tag-sqlite-e-3ybjsg
branch
from
August 27, 2026 20:23
cf5f0bf to
76f670b
Compare
shrima-cf
reviewed
Aug 27, 2026
| } | ||
| }; | ||
|
|
||
| KJ_TEST("SQLite open errors are tagged for DO Sentry") { |
Contributor
There was a problem hiding this comment.
There are already test cases fro SQLITE_NOMEM, could you add the SENTRY_DO text to that as well to verify that code path?
Member
Author
There was a problem hiding this comment.
good point, added more test coverage
jtolio
force-pushed
the
jolio/tag-sqlite-e-3ybjsg
branch
from
August 28, 2026 15:34
ca279c0 to
701b3b2
Compare
jtolio
force-pushed
the
jolio/tag-sqlite-e-3ybjsg
branch
from
August 29, 2026 03:57
701b3b2 to
86520ca
Compare
Prefix existing SQLite open and VFS exception descriptions so they are routed to the Durable Objects Sentry project without changing exception control flow.
jtolio
force-pushed
the
jolio/tag-sqlite-e-3ybjsg
branch
from
August 29, 2026 04:06
86520ca to
bc9a0fb
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## jolio/instrument-l-lziro4 #7150 +/- ##
============================================================
Coverage ? 35.65%
============================================================
Files ? 814
Lines ? 258962
Branches ? 19578
============================================================
Hits ? 92329
Misses ? 155572
Partials ? 11061 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prefix existing SQLite open and VFS exception descriptions so they are routed to the Durable Objects Sentry project without changing exception control flow.