Fix delayed sub-agent WebSocket operations - #2090
Merged
Merged
Conversation
Co-authored-by: Dustin Graham <dustin.graham@hhandr.com>
🦋 Changeset detectedLatest commit: 1760fcf The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
agents
@cloudflare/ai-chat
@cloudflare/channels
@cloudflare/codemode
hono-agents
@cloudflare/shell
@cloudflare/think
@cloudflare/voice
@cloudflare/worker-bundler
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #2027. Fixes #2055.
Why
A sub-agent's virtual WebSocket
Connectionlives longer than the Workers RPC bridge used to forward one browser frame. Delayed work could therefore callconnection.send()through a bridge that had already been disposed.Think exposed this when
STREAM_PENDINGarrived but the laterSTREAM_RESUMINGsend was dropped, leaving the client waiting for its 60-second timeout. #2027 fixes which bridge an in-flight callable reply uses; this PR handles connection activity after that frame has finished.What changed
send,setState, andclosecalls through the durable root Agent, in call order, with failures reported.Validation
pnpm run checkSTREAM_PENDING → STREAM_RESUMING → done