Fix quoted html being empty when the quote is only an image - #82
Open
kraklo wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apologies if this is missing something, not sure what the contribution guidelines are.
Came across a case where people were forwarding emails that were only an image. Because the forwarded content wasn't any text, the line would get stripped out and you'd only get an
html_topwith no quoted content. Also incidentally fixes #22The fix I'm proposing here is to add some "text" for the image line so it isn't entirely stripped out. The choice of a Unicode object replacement character was entirely arbitrary. Happy to swap it out for any other string if preferred.