Skip to content

gh-507: Pull request to integrate mg binned boost emulator#506

Open
sankarshana16 wants to merge 10 commits into
mainfrom
feature/binned_mg_emulator
Open

gh-507: Pull request to integrate mg binned boost emulator#506
sankarshana16 wants to merge 10 commits into
mainfrom
feature/binned_mg_emulator

Conversation

@sankarshana16

@sankarshana16 sankarshana16 commented Apr 30, 2026

Copy link
Copy Markdown

🚀 Pull Request Checklist

✅ Summary

This pull request is for the integration of the binned mg emulator (https://github.com/sankarshana16/mg_binned_boost_emulator) into Cloelib.

🔄 Changes

  • Added mg_emulator python file that wraps the emulator and provides the matter power spectrum, linear growth factor, growth rate and sigma_8 according the Cloelib structure.
  • Modified photo,py to modify lensing, i.e., re-weight it by \Sigma, which is provided in input to the emulator.

🛠 How to Test

📝 Documentation

  • This PR does not require documentation changes

✅ PR Checklist for Developers

  • I have titled this PR before merging as "gh-#:", where "#" represents the task it closes
  • I have run locally pre-commit using pre-commit run --all-files
  • I have tested my changes locally
  • No new warnings or errors introduced
  • I have updated documentation (if applicable)
  • My changes do not introduce breaking changes (i.e: the package still gets installed)
  • I have added unit tests (if applicable)
  • I have consistently updated the GitHub information for the project, including milestones, task types, and other relevant details.

✅ PR Checklist for Reviewers

  • The next PR targets the correct branch
  • CI tests have run and passed for the latest commit on the source branch
  • Check that the code can still be installed if new packages are imported
  • If necessary, the notebooks in the playground will be updated in a corresponding follow-up PR
  • Coverage percentage is retained or increased
  • Quality of new/changed code is acceptable
  • Quality of new/changed unit tests is acceptable
  • No data files have been included in the commits
  • Implementation follows the agreed task description point by point
  • Check that any added folder/file has been added to the README.md file
  • Check that the documentation has been updated accordantly
  • Check that the corresponding branch has been deleted after merging. If not, delete it

@gcanasherrera

Copy link
Copy Markdown
Member

@sankarshana16 make sure that there is a task associated to this PR. Also, why have you changed the template for developers? :D

Change the title of this PR.
Docs still need to be adjusted (also README).

@gcanasherrera

Copy link
Copy Markdown
Member

Pull from the main. This should solve the BNT issue.

@gcanasherrera gcanasherrera added this to the v0.11 milestone Apr 30, 2026
Comment thread docs/README_binned.mg Outdated
@@ -0,0 +1,230 @@
# Modified Gravity Euclid Module (CLOE Integration)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't belong here. Modify the docs.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I've moved the file to the docs folder.

@sankarshana16 sankarshana16 Apr 30, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also merged with main now, all checks have passed! :-D

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not what I meant. What I meant is that you need to update cloelib docs as a whole, including this.

Could you please check out how #493 is currently updating the docs? @ivansladoljev can give you a hand

Comment thread cloelib/observables/photo.py
@sankarshana16 sankarshana16 changed the title Pull reuest to integrate binned emulator into cloelib gh-507: Pull reuest to integrate binned emulator into cloelib Apr 30, 2026
@sankarshana16 sankarshana16 changed the title gh-507: Pull reuest to integrate binned emulator into cloelib gh-507: Pull request to integrate binned emulator into cloelib Apr 30, 2026
@sankarshana16

Copy link
Copy Markdown
Author

Okay, I've fixed the developers checklist too.
I thought we were supposed to only leave those points that are ticked in! My bad

@gcanasherrera gcanasherrera changed the title gh-507: Pull request to integrate binned emulator into cloelib gh-507: Pull request to integrate mg binned boost emulator May 1, 2026
@gcanasherrera gcanasherrera added the priority For PM purposes label May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority For PM purposes th-1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants