gh-268: including CMB lensing#422
Merged
Merged
Conversation
…tant z_star in jax_cosmology.
arthurmloureiro
requested changes
Feb 5, 2026
arthurmloureiro
left a comment
Member
There was a problem hiding this comment.
Excellent stuff @raphkou !
Just a few questions and comments!
…re/cmb-lensing
Member
|
Hey @raphkou , I was reviewing this more in detail, and I guess it is fine the way that it is, but, could we please update the docs and make sure that we are compatible with |
Contributor
Author
|
Hi @gcanasherrera, thanks for reviewing this PR. I have updated the code so that it is indeed compatible with numpy>2. It seems to be alright now. |
Member
|
For Guada to remember: this is being well taken care of, just on hold due to holidays. |
Member
|
@all-contributors please add @raphkou for code, ideas, docs |
Contributor
|
I've put up a pull request to add @raphkou! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request Checklist
✅ Summary
This PR allows computing CMB lensing power spectrum and cross-correlations with position and shear tracers.
🔄 Changes
🛠 How to Test
I added the notebook cmb.ipynb in the playground (see PR cloe-org/playground#116), which shows how to compute the CMB lensing power spectrum and cross-correlations, and performs a benchmark against CAMB and CCL.
📝 Documentation
🏗 Related Issues
Resolves #268.
📌 Additional Notes
Pseudo-cl computation not implemented yet.
✅ PR Checklist for Developers
pre-commit run --all-files✅ PR Checklist for Reviewers
playgroundwill be updated in a corresponding follow-up PRREADME.mdfile