Skip to content

gh-217: nonlinear halo model reaction boost v0.2#344

Merged
gcanasherrera merged 14 commits into
mainfrom
217-hmr-boost-v0.9
May 12, 2026
Merged

gh-217: nonlinear halo model reaction boost v0.2#344
gcanasherrera merged 14 commits into
mainfrom
217-hmr-boost-v0.9

Conversation

@nebblu

@nebblu nebblu commented Nov 14, 2025

Copy link
Copy Markdown
Member

🚀 Pull Request Checklist

✅ Summary

This is addressing issue #217 . The module has been updated to be compatible with CLOE v0.9 and has additional features and beyond-LCDM models compared to the previous PR.

🔄 Changes

  • New cloelib/cosmology/ReACTEmu_cosmology.py file that calculates the halo model reaction boost and optionally applies it to a nonlinear LCDM spectrum;
  • Module includes various redshift extrapolation options and a number of modified gravity and dark energy model options;
  • Has a test file in tests/test_ReACTEmu.py;
  • Added some documentation in README_react.md.
  • Added an ipynb tutorial in playground related to issue #75.

🛠 How to Test

Download the validation data (see README_react.md) and place it in the tests folder. Then run

pytest tests/test_ReACTEmu.py

📝 Documentation

  • This PR updates documentation

🏗 Related Issues

This issue closes #217


✅ PR Checklist for Developers

  • I have titled this PR before merging as "gh-#:", where "#" represents the task it closes
  • My code follows the repository's coding style
  • I have tested my changes locally
  • No new warnings or errors introduced
  • I have updated documentation (if applicable)
  • My changes do not introduce breaking changes
  • I have added tests (if applicable)
  • I have consistently updated the GitHub information for the project, including milestones, task types, and other relevant details.

✅ PR Checklist for Reviewers

  • The next PR targets the correct branch
  • CI tests have run and passed for the latest commit on the source branch
  • Check that the code can still be installed if new packages are imported
  • If necessary, the notebooks in the playground will be updated in a corresponding follow-up PR
  • Coverage percentage is retained or increased
  • Quality of new/changed code is acceptable
  • Quality of new/changed unit tests is acceptable
  • No data files have been included in the commits
  • Implementation follows the agreed task description point by point
  • Check that there are no No newline at the end of file warnings
  • Check that any added folder/file has been added to the README.md file
  • Check that the implementation follows the contributing guidelines and style choices
  • Check that the documentation has been updated accordantly
  • Check that the corresponding branch has been deleted after merging. If not, delete it

@gcanasherrera

Copy link
Copy Markdown
Member

The problem here is that you need to run pre-commit locally first and the push. Install pre-commit through pip and then:

pre-commit run --all-files

@gcanasherrera

Copy link
Copy Markdown
Member

You need to add the new code to the CI.yaml

@gcanasherrera gcanasherrera added th-1 background-perturbations Tasks related to Background and Perturbations labels Nov 24, 2025
@gcanasherrera

Copy link
Copy Markdown
Member

Have a look at the implementation of EE2 please @nebblu, #367

make sure that you will still be able to output sigma8_0 as a new function

Thanks a lot!

@gcanasherrera
gcanasherrera self-requested a review January 12, 2026 15:48
@gcanasherrera gcanasherrera added this to the v0.10 milestone Jan 20, 2026
@gcanasherrera

Copy link
Copy Markdown
Member

Same as #215, hold on for a bit.

@nebblu
nebblu force-pushed the 217-hmr-boost-v0.9 branch from 163ca9e to 2368cc0 Compare April 29, 2026 08:39
@gcanasherrera

Copy link
Copy Markdown
Member

@nebblu could you simply fix the conflicts so we can merge?

@gcanasherrera gcanasherrera added the priority For PM purposes label May 11, 2026
nebblu added 2 commits May 12, 2026 09:53
Removed extra blank lines in the perturbations documentation.
@nebblu

nebblu commented May 12, 2026

Copy link
Copy Markdown
Member Author

Done :)

@gcanasherrera
gcanasherrera merged commit 872a2df into main May 12, 2026
8 checks passed
@gcanasherrera
gcanasherrera deleted the 217-hmr-boost-v0.9 branch May 12, 2026 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

background-perturbations Tasks related to Background and Perturbations priority For PM purposes th-1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding mgemu emulator for halo model reaction correction beyond LCDM models

2 participants