Repository navigation
Add describe-by selector for resources with ID and NAME columns - #25
Merged
Merged
Conversation
When the current tab's table has both an ID and a NAME column, pressing 'd' now opens a selector asking whether to describe the selected resource(s) by Name or by ID, then runs kubectl describe using the chosen identifier. Tabs that show only one of the two (the common case) are unchanged and describe immediately by NAME. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011DhepXnDKGecoNaYYnKgWQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When describing Kubernetes resources that have both ID and NAME columns, users are now prompted to choose which identifier to use for the describe operation. This provides flexibility for resources where both identifiers are available.
Key Changes
currentTabHasIDAndName()method to detect when a resource table has both ID and NAME columnsopenDescribeBySelector()to display a dialog asking users to choose between "Name" or "ID" for describing resourcesgetSelectedResourceInfo()into a more flexiblegetSelectedResourceInfoBy(idColumn)that accepts a column parameter, with the original method now delegating to itdescribeResources()to accept anidColumnparameter specifying which column provides the resource identifierhandleSelectorResult()to trigger the describe operation with the user's choiceapp_test.gofor the new functionality, including edge cases like nil resources and case-insensitive column matchingImplementation Details
https://claude.ai/code/session_011DhepXnDKGecoNaYYnKgWQ