fix reported difference in datetime when passed in a date in the future (addresses #44)#45
Merged
hlship merged 6 commits intoclj-commons:masterfrom May 4, 2026
Merged
Conversation
we do this by simply "coercing" the :now-dt argument to be ~at midnight as well~ when then-dt is a java.time.LocalDate
Collaborator
|
This looks like a good idea, but need to figure out how to make the ClojureScript tests pass. I haven't look into it yet. |
Contributor
Author
The tests should be fixed now. Please have a look! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #44
I considered a couple of approaches, ranging from adding the current time (and then with a +1 second; good grief! just in order to be able to bump it up at the nanosecond-level to just past 24 hours) to
then-dtusing atTime, to maybe doing something with thecondif passed in a date; but ultimately settled on this one as the most elegant.A couple of notes:
I must apologize for not adding in tests for this just yet; I can take a look at this in time to come (but would also be fine getting help for this)DONE(datetime (java.time.LocalDate/now))equal"today"(rather than "a moment ago"); I think that makes sense