Add Titan embeddings support to the Bedrock bridge#4
Draft
jaksa-v wants to merge 1 commit intoclinically-au:mainfrom
Draft
Add Titan embeddings support to the Bedrock bridge#4jaksa-v wants to merge 1 commit intoclinically-au:mainfrom
jaksa-v wants to merge 1 commit intoclinically-au:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clinically/prism-bedrock ^0.1.2Why
Once Titan embeddings support exists in
clinically/prism-bedrock, this bridge still needs to map Laravel AI embedding requests onto the Bedrock-specific provider options that Titan expects. Without that step,dimensions()and related Bedrock embeddings options never reach the underlying request.What changed
BedrockProvider.BedrockPrismGatewayso provider options are passed through correctly.^0.1.2.Dependency
This PR depends on the Prism Titan embeddings work:
Review note
The only overlap with #1 is the minimal Bedrock service provider namespace fix in the tests. This PR does not include the separate image-provider or provider-options merge work.
Verification
php vendor/bin/phpunit