Feat: Organization Social Media Links (new version from master) - #1097
Open
JoshKornfeld wants to merge 18 commits into
Open
JoshKornfeld wants to merge 18 commits into
JoshKornfeld wants to merge 18 commits into
Conversation
make black . All changes included for social media links
JoshKornfeld
requested review from
ddhanesha and
positiveimpact
as code owners
October 17, 2022 09:09
Co-authored-by: Christoph Stoll <christoph1.stoll@gmail.com>
Contributor
|
@JoshKornfeld please resolve all merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #1071
Backend:
Added a SocialMediaChannel & SocialMediaLink model. A channel is a constant that points to a social media site. The link binds this channel to an organization.
Updated serializers: organization.py and created new ones in social_media.py. Modified organization_views for creating/editing organizations.
Frontend:
Users can click a + icon on a chip that reads add social media. This opens a selectfield dialog from which they can pick from 5 different social medias. Depending on the type of social media, the user will need to either insert the full link or just the handle. A second textfield will open and will display the full URL for the user if only the handle is required. Once added, a chip dispaying the icon and name, with the option to delete it via a close button, will appear on the edit page. When the chip is hovered, the url will display. When viewing the organization page, the social media links will be displayed via their icons that when clicked, will open a new tab with their social media page opened.
The website of the organization has been moved from the center to the left under their avatar.
Also fixed where selecting empty field, the page doesn't crash for types or social media options.
TODOS:
Select field for German page has strange formatting. (dialog has a scroll, texts are too long).
Side note: for organization types, I don't believe whatever is being input into additional information is being saved to the backend
Test plan
Before landing
yarn lintpasses (frontend)yarn formatpasses (frontend)make formatpasses (backend)