Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/ckeditor5-alignment/src/alignmentui.ts
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,8 @@ export class AlignmentUI extends Plugin {
dropdownView.bind( 'isEnabled' ).to( command, 'isEnabled' );

// Focus the editable after executing the command.
// Overrides a default behaviour where the focus is moved to the dropdown button (#12125).
// Overrides a default behaviour where the focus is moved to the dropdown button.
// See https://github.com/ckeditor/ckeditor5/issues/12125.
this.listenTo( dropdownView, 'execute', () => {
editor.editing.view.focus();
} );
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ export function blockAutoformatEditing(

const blockToFormat = entry.position.parent;

// Block formatting should be disabled in codeBlocks (#5800).
// Block formatting should be disabled in codeBlocks (https://github.com/ckeditor/ckeditor5/issues/5800).
if ( blockToFormat.is( 'element', 'codeBlock' ) ) {
return;
}
Expand Down
2 changes: 1 addition & 1 deletion packages/ckeditor5-block-quote/theme/blockquote.css
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*/

.ck-content blockquote {
/* See #12 */
/* See https://github.com/ckeditor/ckeditor5-block-quote/issues/12 */
overflow: hidden;

/* https://github.com/ckeditor/ckeditor5-block-quote/issues/15 */
Expand Down
2 changes: 1 addition & 1 deletion packages/ckeditor5-bookmark/src/bookmarkui.ts
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ export class BookmarkUI extends Plugin {
public override destroy(): void {
super.destroy();

// Destroy created UI components as they are not automatically destroyed (see ckeditor5#1341).
// Destroy created UI components as they are not automatically destroyed (see https://github.com/ckeditor/ckeditor5/issues/1341).
if ( this.formView ) {
this.formView.destroy();
}
Expand Down
2 changes: 1 addition & 1 deletion packages/ckeditor5-bookmark/tests/bookmarkui.js
Original file line number Diff line number Diff line change
Expand Up @@ -777,7 +777,7 @@ describe( 'BookmarkUI', () => {
} );

it( 'should add #formView to the balloon and attach the balloon to the marker element when selection is collapsed', () => {
// (#7926)
// (https://github.com/ckeditor/ckeditor5/issues/7926)
_setModelData( editor.model, '<paragraph>f[]oo</paragraph>' );
bookmarkUIFeature._showFormView();
formView = bookmarkUIFeature.formView;
Expand Down
2 changes: 1 addition & 1 deletion packages/ckeditor5-clipboard/src/utils/viewtoplaintext.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export function viewToPlainText(
}

if ( viewItem.is( 'element', 'br' ) ) {
return '\n'; // Convert soft breaks to single line break (#8045).
return '\n'; // Convert soft breaks to single line break (https://github.com/ckeditor/ckeditor5/issues/8045).
}

/**
Expand Down
2 changes: 1 addition & 1 deletion packages/ckeditor5-clipboard/tests/pasteplaintext.js
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ describe( 'PastePlainText', () => {
} );

it( 'should work if the insertContent event is cancelled', () => {
// (#7887).
// (https://github.com/ckeditor/ckeditor5/issues/7887).
_setModelData( model, '<paragraph><$text bold="true">Bolded []text.</$text></paragraph>' );

const dataTransferMock = createDataTransfer( {
Expand Down
2 changes: 1 addition & 1 deletion packages/ckeditor5-code-block/src/codeblockcommand.ts
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ export class CodeBlockCommand extends Command {
writer.setAttribute( 'language', language, block );
schema.removeDisallowedAttributes( [ block ], writer );

// Remove children of the `codeBlock` element that are not allowed. See #9567.
// Remove children of the `codeBlock` element that are not allowed. See https://github.com/ckeditor/ckeditor5/issues/9567.
Array.from( block.getChildren() )
.filter( child => !schema.checkChild( block, child ) )
.forEach( child => writer.remove( child ) );
Expand Down
2 changes: 1 addition & 1 deletion packages/ckeditor5-code-block/tests/codeblockediting.js
Original file line number Diff line number Diff line change
Expand Up @@ -857,7 +857,7 @@ describe( 'CodeBlockEditing', () => {
} );
} );

// See #5910.
// See https://github.com/ckeditor/ckeditor5/issues/5910.
it( 'should allow to indent an entire code block with at least two lines', () => {
const element = document.createElement( 'div' );
document.body.appendChild( element );
Expand Down
2 changes: 1 addition & 1 deletion packages/ckeditor5-core/tests/editor/editor.js
Original file line number Diff line number Diff line change
Expand Up @@ -1422,7 +1422,7 @@ describe( 'Editor', () => {
editor.model.document.createRoot( '$root', 'main' );
editor.model.document.createRoot( '$root', 'secondRoot' );
editor.model.schema.extend( '$text', { allowIn: '$root' } );
editor.fire( 'ready' ); // (#6139)
editor.fire( 'ready' ); // (https://github.com/ckeditor/ckeditor5/issues/6139)
} );

afterEach( async () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ describe( 'ElementApiMixin', () => {
editor = new CustomEditor();
editor.model.document.createRoot();
editor.model.schema.extend( '$text', { allowIn: '$root' } );
editor.fire( 'ready' ); // (#6139)
editor.fire( 'ready' ); // (https://github.com/ckeditor/ckeditor5/issues/6139)
} );

afterEach( async () => {
Expand Down
3 changes: 2 additions & 1 deletion packages/ckeditor5-emoji/src/emojimention.ts
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,8 @@ export class EmojiMention extends Plugin {
return [];
}

// If the repository plugin is not available, return an empty feed to avoid confusion. See: #17842.
// If the repository plugin is not available, return an empty feed to avoid confusion.
// See: https://github.com/ckeditor/ckeditor5/issues/17842.
if ( !this._isEmojiRepositoryAvailable ) {
return [];
}
Expand Down
2 changes: 1 addition & 1 deletion packages/ckeditor5-emoji/src/emojipicker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ export class EmojiPicker extends Plugin {
*/
public showUI( searchValue: string = '' ): void {
// Show visual selection on a text when the contextual balloon is displayed.
// See #17654.
// See https://github.com/ckeditor/ckeditor5/issues/17654.
this._showFakeVisualSelection();

if ( !this.emojiPickerView ) {
Expand Down
4 changes: 2 additions & 2 deletions packages/ckeditor5-emoji/tests/emojipicker.js
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,7 @@ describe( 'EmojiPicker', () => {
} ).to.not.throw();
} );

// See #17819.
// See https://github.com/ckeditor/ckeditor5/issues/17819.
it( 'should not change the selection after opening the UI', async () => {
_setModelData(
editor.model,
Expand All @@ -447,7 +447,7 @@ describe( 'EmojiPicker', () => {
);
} );

// See #17964
// See https://github.com/ckeditor/ckeditor5/issues/17964
it( 'should have the ck-emoji-picker-balloon class to make sure z-index does not conflict with the dialog system', () => {
emojiPicker.showUI();

Expand Down
3 changes: 2 additions & 1 deletion packages/ckeditor5-engine/src/conversion/downcasthelpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1657,7 +1657,8 @@ function changeAttribute( attributeCreator: DowncastAttributeCreatorFunction ) {
const viewWriter = conversionApi.writer;

// If model item cannot be mapped to a view element, it means item is not an `Element` instance but a `ModelTextProxy` node.
// Only elements can have attributes in a view so do not proceed for anything else (#1587).
// Only elements can have attributes in a view so do not proceed for anything else.
// See https://github.com/ckeditor/ckeditor5-engine/issues/1587.
if ( !viewElement ) {
/**
* This error occurs when a {@link module:engine/model/textproxy~ModelTextProxy text node's} attribute is to be downcasted
Expand Down
2 changes: 1 addition & 1 deletion packages/ckeditor5-engine/src/conversion/upcasthelpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1159,7 +1159,7 @@ function setAttributeOn(
}

// Mark the node as consumed even if the attribute will not be updated because it's in a valid context (schema)
// and would be converted if the attribute wouldn't be present. See #8921.
// and would be converted if the attribute wouldn't be present. See https://github.com/ckeditor/ckeditor5/issues/8921.
result = true;

// Do not override the attribute if it's already present.
Expand Down
2 changes: 1 addition & 1 deletion packages/ckeditor5-engine/src/model/element.ts
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ export class ModelElement extends ModelNode {
ModelElement.prototype.is = function( this: ModelElement, type: string, name?: string ): boolean {
if ( !name ) {
return type === 'element' || type === 'model:element' ||
// From super.is(). This is highly utilised method and cannot call super. See ckeditor/ckeditor5#6529.
// From super.is(). This is highly utilised method and cannot call super. See https://github.com/ckeditor/ckeditor5/issues/6529.
type === 'node' || type === 'model:node';
}

Expand Down
2 changes: 1 addition & 1 deletion packages/ckeditor5-engine/src/model/liveposition.ts
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ export class ModelLivePosition extends /* #__PURE__ */ EmitterMixin( ModelPositi
// Proper overload would interfere with that.
ModelLivePosition.prototype.is = function( type: string ): boolean {
return type === 'livePosition' || type === 'model:livePosition' ||
// From super.is(). This is highly utilised method and cannot call super. See ckeditor/ckeditor5#6529.
// From super.is(). This is highly utilised method and cannot call super. See https://github.com/ckeditor/ckeditor5/issues/6529.
type == 'position' || type === 'model:position';
} as any;

Expand Down
2 changes: 1 addition & 1 deletion packages/ckeditor5-engine/src/model/liverange.ts
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ export class ModelLiveRange extends /* #__PURE__ */ EmitterMixin( ModelRange ) {
// Proper overload would interfere with that.
ModelLiveRange.prototype.is = function( type: string ): boolean {
return type === 'liveRange' || type === 'model:liveRange' ||
// From super.is(). This is highly utilised method and cannot call super. See ckeditor/ckeditor5#6529.
// From super.is(). This is highly utilised method and cannot call super. See https://github.com/ckeditor/ckeditor5/issues/6529.
type == 'range' || type === 'model:range';
} as any;

Expand Down
6 changes: 4 additions & 2 deletions packages/ckeditor5-engine/src/model/position.ts
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,8 @@ export class ModelPosition extends ModelTypeCheckable {
* Node directly after this position. Returns `null` if this position is at the end of its parent, or if it is in a text node.
*/
public get nodeAfter(): ModelNode | null {
// Cache the parent and reuse for performance reasons. See #6579 and #6582.
// Cache the parent and reuse for performance reasons.
// See https://github.com/ckeditor/ckeditor5/issues/6579 and https://github.com/ckeditor/ckeditor5/issues/6582.
const parent = this.parent;

return getNodeAfterPosition( this, parent, getTextNodeAtPosition( this, parent ) );
Expand All @@ -238,7 +239,8 @@ export class ModelPosition extends ModelTypeCheckable {
* Node directly before this position. Returns `null` if this position is at the start of its parent, or if it is in a text node.
*/
public get nodeBefore(): ModelNode | null {
// Cache the parent and reuse for performance reasons. See #6579 and #6582.
// Cache the parent and reuse for performance reasons.
// See https://github.com/ckeditor/ckeditor5/issues/6579 and https://github.com/ckeditor/ckeditor5/issues/6582.
const parent = this.parent;

return getNodeBeforePosition( this, parent, getTextNodeAtPosition( this, parent ) );
Expand Down
4 changes: 2 additions & 2 deletions packages/ckeditor5-engine/src/model/rootelement.ts
Original file line number Diff line number Diff line change
Expand Up @@ -94,14 +94,14 @@ export class ModelRootElement extends ModelElement {
ModelRootElement.prototype.is = function( this: ModelRootElement, type: string, name?: string ): boolean {
if ( !name ) {
return type === 'rootElement' || type === 'model:rootElement' ||
// From super.is(). This is highly utilised method and cannot call super. See ckeditor/ckeditor5#6529.
// From super.is(). This is highly utilised method and cannot call super. See https://github.com/ckeditor/ckeditor5/issues/6529.
type === 'element' || type === 'model:element' ||
type === 'node' || type === 'model:node';
}

return name === this.name && (
type === 'rootElement' || type === 'model:rootElement' ||
// From super.is(). This is highly utilised method and cannot call super. See ckeditor/ckeditor5#6529.
// From super.is(). This is highly utilised method and cannot call super. See https://github.com/ckeditor/ckeditor5/issues/6529.
type === 'element' || type === 'model:element'
);
} as any;
2 changes: 1 addition & 1 deletion packages/ckeditor5-engine/src/model/text.ts
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,6 @@ ModelText.prototype.is = function( type: string ): boolean {
return type === '$text' || type === 'model:$text' ||
// This are legacy values kept for backward compatibility.
type === 'text' || type === 'model:text' ||
// From super.is(). This is highly utilised method and cannot call super. See ckeditor/ckeditor5#6529.
// From super.is(). This is highly utilised method and cannot call super. See https://github.com/ckeditor/ckeditor5/issues/6529.
type === 'node' || type === 'model:node';
} as any;
6 changes: 4 additions & 2 deletions packages/ckeditor5-engine/src/model/treewalker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,8 @@ export class ModelTreeWalker implements Iterable<ModelTreeWalkerValue> {
}

// Get node just after the current position.
// Use a highly optimized version instead of checking the text node first and then getting the node after. See #6582.
// Use a highly optimized version instead of checking the text node first and then getting the node after.
// See https://github.com/ckeditor/ckeditor5/issues/6582.
const textNodeAtPosition = getTextNodeAtPosition( position, parent );
const node = textNodeAtPosition || getNodeAfterPosition( position, parent, textNodeAtPosition );

Expand Down Expand Up @@ -318,7 +319,8 @@ export class ModelTreeWalker implements Iterable<ModelTreeWalkerValue> {
}

// Get node just before the current position.
// Use a highly optimized version instead of checking the text node first and then getting the node before. See #6582.
// Use a highly optimized version instead of checking the text node first and then getting the node before.
// See https://github.com/ckeditor/ckeditor5/issues/6582.
const positionParent = position.parent;
const textNodeAtPosition = getTextNodeAtPosition( position, positionParent );
const node = textNodeAtPosition || getNodeBeforePosition( position, positionParent, textNodeAtPosition );
Expand Down
4 changes: 2 additions & 2 deletions packages/ckeditor5-engine/src/view/attributeelement.ts
Original file line number Diff line number Diff line change
Expand Up @@ -217,13 +217,13 @@ export class ViewAttributeElement extends ViewElement {
ViewAttributeElement.prototype.is = function( this: ViewAttributeElement, type: string, name?: string ): boolean {
if ( !name ) {
return type === 'attributeElement' || type === 'view:attributeElement' ||
// From super.is(). This is highly utilised method and cannot call super. See ckeditor/ckeditor5#6529.
// From super.is(). This is highly utilised method and cannot call super. See https://github.com/ckeditor/ckeditor5/issues/6529.
type === 'element' || type === 'view:element' ||
type === 'node' || type === 'view:node';
} else {
return name === this.name && (
type === 'attributeElement' || type === 'view:attributeElement' ||
// From super.is(). This is highly utilised method and cannot call super. See ckeditor/ckeditor5#6529.
// From super.is(). This is highly utilised method and cannot call super. See https://github.com/ckeditor/ckeditor5/issues/6529.
type === 'element' || type === 'view:element'
);
}
Expand Down
7 changes: 4 additions & 3 deletions packages/ckeditor5-engine/src/view/containerelement.ts
Original file line number Diff line number Diff line change
Expand Up @@ -73,13 +73,13 @@ export class ViewContainerElement extends ViewElement {
ViewContainerElement.prototype.is = function( this: ViewContainerElement, type: string, name?: string ): boolean {
if ( !name ) {
return type === 'containerElement' || type === 'view:containerElement' ||
// From super.is(). This is highly utilised method and cannot call super. See ckeditor/ckeditor5#6529.
// From super.is(). This is highly utilised method and cannot call super. See https://github.com/ckeditor/ckeditor5/issues/6529.
type === 'element' || type === 'view:element' ||
type === 'node' || type === 'view:node';
} else {
return name === this.name && (
type === 'containerElement' || type === 'view:containerElement' ||
// From super.is(). This is highly utilised method and cannot call super. See ckeditor/ckeditor5#6529.
// From super.is(). This is highly utilised method and cannot call super. See https://github.com/ckeditor/ckeditor5/issues/6529.
type === 'element' || type === 'view:element'
);
}
Expand All @@ -94,7 +94,8 @@ export function getViewFillerOffset( this: ViewContainerElement ): number | null
const children = [ ...this.getChildren() ];
let lastChild: ViewNode | undefined = children[ this.childCount - 1 ];

// Block filler is required after a `<br>` if it's the last element in its container. See #1422.
// Block filler is required after a `<br>` if it's the last element in its container.
// See https://github.com/ckeditor/ckeditor5-engine/issues/1422.
if ( lastChild && lastChild.is( 'element', 'br' ) ) {
return this.childCount;
}
Expand Down
8 changes: 5 additions & 3 deletions packages/ckeditor5-engine/src/view/domconverter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ export class ViewDomConverter {
if ( viewElementOrFragment.name === '$comment' ) {
domElement = this._domDocument.createComment( viewElementOrFragment.getCustomProperty( '$rawContent' ) as string );
} else {
// UIElement has its own render() method (see #799).
// UIElement has its own render() method (see https://github.com/ckeditor/ckeditor5/issues/799).
domElement = viewElementOrFragment.render( this._domDocument, this );
}

Expand Down Expand Up @@ -1566,7 +1566,8 @@ export class ViewDomConverter {
// Change all consecutive whitespace characters (from the [ \n\t\r] set –
// see https://github.com/ckeditor/ckeditor5-engine/issues/822#issuecomment-311670249) to a single space character.
// That's how multiple whitespaces are treated when rendered, so we normalize those whitespaces.
// We're replacing 1+ (and not 2+) to also normalize singular \n\t\r characters (#822).
// We're replacing 1+ (and not 2+) to also normalize singular \n\t\r characters.
// See https://github.com/ckeditor/ckeditor5/issues/822.
data = node.data.replace( /[ \n\t\r]{1,}/g, ' ' );
nodeEndsWithSpace = /[^\S\u00A0]/.test( data.charAt( data.length - 1 ) );

Expand All @@ -1593,7 +1594,8 @@ export class ViewDomConverter {
// At the beginning and end of a block element, Firefox inserts normal space + <br> instead of non-breaking space.
// This means that the text node starts/end with normal space instead of non-breaking space.
// This causes a problem because the normal space would be removed in `.replace` calls above. To prevent that,
// the inline filler is removed only after the data is initially processed (by the `.replace` above). See ckeditor5#692.
// the inline filler is removed only after the data is initially processed (by the `.replace` above).
// See https://github.com/ckeditor/ckeditor5/issues/692.
data = getDataWithoutFiller( data );

// Block filler handling.
Expand Down
4 changes: 2 additions & 2 deletions packages/ckeditor5-engine/src/view/editableelement.ts
Original file line number Diff line number Diff line change
Expand Up @@ -114,14 +114,14 @@ export class ViewEditableElement extends /* #__PURE__ */ ObservableMixin( ViewCo
ViewEditableElement.prototype.is = function( this: ViewEditableElement, type: string, name?: string ): boolean {
if ( !name ) {
return type === 'editableElement' || type === 'view:editableElement' ||
// From super.is(). This is highly utilised method and cannot call super. See ckeditor/ckeditor5#6529.
// From super.is(). This is highly utilised method and cannot call super. See https://github.com/ckeditor/ckeditor5/issues/6529.
type === 'containerElement' || type === 'view:containerElement' ||
type === 'element' || type === 'view:element' ||
type === 'node' || type === 'view:node';
} else {
return name === this.name && (
type === 'editableElement' || type === 'view:editableElement' ||
// From super.is(). This is highly utilised method and cannot call super. See ckeditor/ckeditor5#6529.
// From super.is(). This is highly utilised method and cannot call super. See https://github.com/ckeditor/ckeditor5/issues/6529.
type === 'containerElement' || type === 'view:containerElement' ||
type === 'element' || type === 'view:element'
);
Expand Down
2 changes: 1 addition & 1 deletion packages/ckeditor5-engine/src/view/element.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1217,7 +1217,7 @@ export class ViewElement extends ViewNode {
ViewElement.prototype.is = function( this: ViewElement, type: string, name?: string ): boolean {
if ( !name ) {
return type === 'element' || type === 'view:element' ||
// From super.is(). This is highly utilised method and cannot call super. See ckeditor/ckeditor5#6529.
// From super.is(). This is highly utilised method and cannot call super. See https://github.com/ckeditor/ckeditor5/issues/6529.
type === 'node' || type === 'view:node';
} else {
return name === this.name && ( type === 'element' || type === 'view:element' );
Expand Down
2 changes: 1 addition & 1 deletion packages/ckeditor5-engine/src/view/emptyelement.ts
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ export class ViewEmptyElement extends ViewElement {
ViewEmptyElement.prototype.is = function( this: ViewEmptyElement, type: string, name?: string ): boolean {
if ( !name ) {
return type === 'emptyElement' || type === 'view:emptyElement' ||
// From super.is(). This is highly utilised method and cannot call super. See ckeditor/ckeditor5#6529.
// From super.is(). This is highly utilised method and cannot call super. See https://github.com/ckeditor/ckeditor5/issues/6529.
type === 'element' || type === 'view:element' ||
type === 'node' || type === 'view:node';
} else {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,8 @@ export class MutationObserver extends Observer {
}
}

// In case only non-relevant mutations were recorded it skips the event and force render (#5600).
// In case only non-relevant mutations were recorded it skips the event and force render.
// See https://github.com/ckeditor/ckeditor5/issues/5600.
if ( mutations.length ) {
// @if CK_DEBUG_TYPING // if ( ( window as any ).logCKETyping ) {
// @if CK_DEBUG_TYPING // _debouncedLine();
Expand Down
Loading