-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[WiP] Skip level lists #20088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
[WiP] Skip level lists #20088
Changes from all commits
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
7be1f5d
Allow skip level lists in the model (commands and postfixers).
mmotyczynska 15162bf
It should be possible to outdent first list item (turn into paragraph…
mmotyczynska 8df7919
Correct how top-level first list item in the list is found.
mmotyczynska b38a39e
Downcast skip-level lists to valid HTML
mmotyczynska 6290717
Align argument handling with previous implementation.
mmotyczynska c6fa743
Merge branch 'cc/9702-downcast-skip-level-lists' into cc/9703-upcast-…
mmotyczynska 26f7091
Upcast skip level lists.
mmotyczynska cf79dac
Fix intermediate list wrappers missing classes in skip-level lists (f…
mmotyczynska 9c50fc1
Improve manual test for skip level lists to be able to dynamically ad…
mmotyczynska 177dd25
Update dev dependencies.
mmotyczynska d70e231
Update manual test so it has initial data after reload.
mmotyczynska 47aeec2
Fix intermediate wrapper merging in skip-level lists with mixed types.
mmotyczynska 61c0e58
Decouple indent block list and list packages (skip-level lists context).
mmotyczynska 3d1beea
Update tests.
mmotyczynska 320a97e
Merge branch 'cc/9701-allow-skip-level-in-model' into cc/9702-downcas…
mmotyczynska d5ab2eb
Fixes after code review.
mmotyczynska 1beaadb
Merge branch 'cc/9702-downcast-skip-level-lists' into cc/9703-upcast-…
mmotyczynska 250bac4
Code review fixes.
mmotyczynska 65158be
Merge branch 'cc/9703-upcast-skip-level-lists' into cc/9704-skip-leve…
mmotyczynska 47297a1
Review changes.
mmotyczynska aaec3c3
Review fixes.
mmotyczynska 0b2c9ca
Merge pull request #20061 from ckeditor/cc/9701-allow-skip-level-in-m…
mmotyczynska ecc197d
Merge pull request #20071 from ckeditor/cc/9702-downcast-skip-level-l…
mmotyczynska b91d7b6
Add test for skip level list and GHS and content inside intermediate …
mmotyczynska 95f9d2a
Merge remote-tracking branch 'origin/master' into cc/epic/9587-skip-l…
mmotyczynska b420c13
Merge branch 'cc/epic/9587-skip-level-lists' into cc/9703-upcast-skip…
mmotyczynska bc9fc2b
Merge branch 'cc/9703-upcast-skip-level-lists' into cc/9704-skip-leve…
mmotyczynska 6ddb096
Merge pull request #20072 from ckeditor/cc/9703-upcast-skip-level-lists
mmotyczynska 6dd8131
Merge pull request #20079 from ckeditor/cc/9704-skip-levels-in-multi-…
mmotyczynska b0adee9
Extend autoformat for lists to accept any number.
mmotyczynska 6307248
Merge pull request #20090 from ckeditor/cc/9705-autoformat-for-number…
mmotyczynska 4c5afd0
Improve detecting which items should be reconverted when using skip-l…
mmotyczynska b8a039c
Merge remote-tracking branch 'origin/cc/epic/9587-skip-level-lists' i…
mmotyczynska 0834c16
Code review fix.
mmotyczynska 257bc3c
Improve collecting list items to be reconverted.
mmotyczynska 9e78878
Don't block indent list item at indent 0 after a skip-level.
mmotyczynska cb78d8a
Update tests.
mmotyczynska 6c34808
Review fix.
mmotyczynska 82866bf
Add one more case to tests.
mmotyczynska 31118e8
Backsace in list item with no same or lower indent preceeding block s…
mmotyczynska 33d46aa
Refactor after code review.
mmotyczynska 8d66f35
Update jsdocs.
mmotyczynska c6b67cd
Merge pull request #20104 from ckeditor/cc/9765-changing-list-start-a…
mmotyczynska 3ec26cd
Merge pull request #20111 from ckeditor/cc/9763-tab-at-list-item-afte…
mmotyczynska 5160363
Merge pull request #20112 from ckeditor/cc/9762-backspace-in-list-ite…
mmotyczynska 1faa8c2
Improve detecting skip-level lists.
mmotyczynska 25f076a
Fix failing tests and coverage.
mmotyczynska 89b5fd7
Merge branch 'master' into cc/epic/9587-skip-level-lists
Mati365 249ca5c
Add skip level list changelogs.
Mati365 19b27a5
Update metadata for skip-level lists.
mmotyczynska 5316c0d
Merge pull request #20144 from ckeditor/cc/9847-metadata-for-skip-lev…
mmotyczynska 0630c42
Merge pull request #20143 from ckeditor/ck/9847
Mati365 577bf41
Merge pull request #20139 from ckeditor/cc/9778-review-detecting-skip…
mmotyczynska File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| --- | ||
| type: Feature | ||
| scope: | ||
| - ckeditor5-list | ||
| - ckeditor5-autoformat | ||
| --- | ||
|
|
||
| Numbered list autoformat now accepts any starting number. Typing any number followed by `.` or `)` and a space (e.g. `5. `) creates a numbered list. When the `list.properties.startIndex` option is enabled, the list starts at the typed number. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| type: Feature | ||
| scope: | ||
| - ckeditor5-list | ||
| --- | ||
|
|
||
| Added support for skip-level lists. List items can now be indented by more than one level at a time by enabling the `list.allowSkipLevels` configuration option. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Undo-on-backspace triggered when autoformat callback declines
Low Severity
When the numbered-list autoformat callback returns
false(because the selection is already inside a numbered list),blockAutoformatEditingstill callsrequestUndoOnBackspace()unconditionally. Previously, the command-string approach exited beforeenqueueChangewhencommand.value === true, avoiding this side effect. Now, typing something like "5. " inside an existing numbered list item correctly preserves the text, but the next backspace press may trigger an undo of the entire recent typing batch instead of just deleting the space character.Reviewed by Cursor Bugbot for commit 5160363. Configure here.