deps: bump mysql2 to 3.24.3 (GHSA-3f6p-5ww8-9rcr, GHSA-rgwj-5xj2-c3m3) - #1140
deps: bump mysql2 to 3.24.3 (GHSA-3f6p-5ww8-9rcr, GHSA-rgwj-5xj2-c3m3)#1140katsugtgz wants to merge 1 commit into
Conversation
|
Hey there, thanks for the PR!
A rogue server isn't a concern, and if some setup gets to a "MITM is possible" scenario, the leaked db password is the least of their problems.
We do not have compression enabled in neither of the call sites: txAdmin/core/deployer/recipeEngine.js Lines 369 to 377 in 8a9a414 txAdmin/core/routes/deployer/actions.js Lines 119 to 126 in 8a9a414 I'll defer this to when we do the next big batch of deps version bumps... which might actually happen on the next txAdmin master-branch update (not just enhanced). And because of that I'm closing this PR, but if I'm missing something (eg details or attack scenario) please do let me know and I'll have a second look :) |
Updates
mysql2to address GHSA-3f6p-5ww8-9rcr and GHSA-rgwj-5xj2-c3m3.Evidence:
package-lock.jsonpinnedmysql2@3.12.0,core/package.jsonrequired^3.11.3mysql2@3.12.0before the update3.24.3Validation:
mysql2after the updateCI=true npm run test --workspacespasses (193 tests in core, 53 passed plus 1 todo in panel), same result as on master before the change.envwithTXDEV_FXSERVER_PATHandTXDEV_VITE_URLwas created first, matching.github/workflows/run-tests.ymlNote: osv-scanner still reports separate advisories for other packages in the lockfile (minimatch, tar, nanoid, ajv, undici, vite and others). This patch only clears the two mysql2 advisories.
Scope: dependency and lockfile update only.