Repository navigation
fix!: let the 👀 reaction through, and name the membership App by its client ID - #41
Conversation
Refs #37 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012Jmn7nJnwMciggj9ThhFYj
|
The zizmor check fails as expected, because the Generated by Claude Code |
|
integration-test: received ready request from https://github.com/cipherstash/workflows/actions/runs/44653007146/attempts/1 Generated by Claude Code |
|
@cipherstash-agent review |
1 similar comment
|
@cipherstash-agent review |
|
integration-test: received comment-command request from https://github.com/cipherstash/workflows/actions/runs/44664199061/attempts/2 Generated by Claude Code |
|
integration-test: received comment-command request from https://github.com/cipherstash/workflows/actions/runs/44665882864/attempts/1 Generated by Claude Code |
The live comment command check found that the 👀 reaction needs pull-requests: write, so v1.0.0 will be tagged after the fix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012Jmn7nJnwMciggj9ThhFYj
The first live comment command (run 44665882864) sent the review request, but adding the 👀 reaction to the pull request's comment failed with HTTP 403 for a token holding only issues: write. The react job, the example caller and the self-test now also grant pull-requests: write, and a test keeps the three in step. Refs #8 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012Jmn7nJnwMciggj9ThhFYj
… variable The App is now named by the required app-client-id input, which callers fill from the organisation variable CLAUDE_REVIEW_APP_CLIENT_ID, instead of the CLAUDE_REVIEW_APP_ID secret. actions/create-github-app-token deprecated its app-id input in favour of client-id, and an ID is not secret, so a variable lets the setup script check it. Only the private key stays a secret. BREAKING CHANGE: callers pass app-client-id and no longer pass the CLAUDE_REVIEW_APP_ID secret. Refs #8 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012Jmn7nJnwMciggj9ThhFYj
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012Jmn7nJnwMciggj9ThhFYj
Requested by User · project thread
Part of #8. These are the last changes before
v1.0.0is tagged.This PR started as "pin the example to v1.0.0". The live comment-command check before tagging found two problems, so the pin is reverted here. It comes back in its own PR once this is merged and tagged.
What the live check found
tobyhede's
@cipherstash-agent reviewcomment on this PR (run 44664199061, attempt 2, and run 44665882864):issues: write.Changes
pull-requests: writefor the reaction. The react job, the example caller and the self-test now grantissues: writeandpull-requests: write. GitHub documentsissues: writeas enough, but it refused on a pull request's comment. The fix can only be proven live after merge, because comment events run the self-test frommain.issues: writemay turn out to be unneeded, but it stays until that's shown.app-client-id, which callers fill from the organisation variableCLAUDE_REVIEW_APP_CLIENT_ID. It replaces theCLAUDE_REVIEW_APP_IDsecret.actions/create-github-app-tokendeprecatedapp-idin favour ofclient-id, and an ID isn't secret, so the setup script can read it to check the install. The user decided this in the setup-script planning.Before merging
CLAUDE_REVIEW_APP_CLIENT_ID, holding the membership App's client ID from its settings page and visible to all repositories. Without it, every membership check after merge fails withmembership-lookup-failed.After merging
@cipherstash-agent reviewon any PR here, from a person's account, to prove the reaction.v1.0.0on the merge commit, then re-pin the example in a follow-up PR.Tests
New
tests/test_permissions.pyandtests/test_membership_app.py, written to fail first. Full suite: 225 tests pass.🤖 Generated with Claude Code
https://claude.ai/code/session_012Jmn7nJnwMciggj9ThhFYj