Skip to content

fix!: let the 👀 reaction through, and name the membership App by its client ID - #41

Merged
tobyhede merged 5 commits into
mainfrom
claude/project-thread-y6piip
Nov 20, 2026
Merged

tobyhede merged 5 commits into
mainfrom
claude/project-thread-y6piip

Conversation

@cipherstash-agent

@cipherstash-agent cipherstash-agent commented Nov 20, 2026 •

Copy link
Copy Markdown

Requested by User · project thread

Part of #8. These are the last changes before v1.0.0 is tagged.

This PR started as "pin the example to v1.0.0". The live comment-command check before tagging found two problems, so the pin is reverted here. It comes back in its own PR once this is merged and tagged.

What the live check found

tobyhede's @cipherstash-agent review comment on this PR (run 44664199061, attempt 2, and run 44665882864):

  • The membership check worked once the App was installed on the organisation, the request was sent, and the stub routine replied.
  • Adding the 👀 reaction failed with HTTP 403. The react job's token held only issues: write.

Changes

  1. pull-requests: write for the reaction. The react job, the example caller and the self-test now grant issues: write and pull-requests: write. GitHub documents issues: write as enough, but it refused on a pull request's comment. The fix can only be proven live after merge, because comment events run the self-test from main. issues: write may turn out to be unneeded, but it stays until that's shown.
  2. Breaking: the App is named by its client ID. There's a new required input, app-client-id, which callers fill from the organisation variable CLAUDE_REVIEW_APP_CLIENT_ID. It replaces the CLAUDE_REVIEW_APP_ID secret. actions/create-github-app-token deprecated app-id in favour of client-id, and an ID isn't secret, so the setup script can read it to check the install. The user decided this in the setup-script planning.

Before merging

  • Create the organisation variable CLAUDE_REVIEW_APP_CLIENT_ID, holding the membership App's client ID from its settings page and visible to all repositories. Without it, every membership check after merge fails with membership-lookup-failed.

After merging

  • Comment @cipherstash-agent review on any PR here, from a person's account, to prove the reaction.
  • Tag v1.0.0 on the merge commit, then re-pin the example in a follow-up PR.

Tests

New tests/test_permissions.py and tests/test_membership_app.py, written to fail first. Full suite: 225 tests pass.

🤖 Generated with Claude Code

https://claude.ai/code/session_012Jmn7nJnwMciggj9ThhFYj

Refs #37

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012Jmn7nJnwMciggj9ThhFYj
@cipherstash-agent cipherstash-agent self-assigned this Nov 20, 2026

Copy link
Copy Markdown
Author

The zizmor check fails as expected, because the v1.0.0 tag does not exist yet: claude-review.yml:51: action's hash pin has mismatched or missing version comment: points to unknown ref. Once v1.0.0 is created on b493c5e, re-running the zizmor job should pass. No code change is needed.


Generated by Claude Code

Copy link
Copy Markdown
Author

integration-test: received ready request from https://github.com/cipherstash/workflows/actions/runs/44653007146/attempts/1


Generated by Claude Code

@tobyhede

Copy link
Copy Markdown
Contributor

@cipherstash-agent review

1 similar comment
@tobyhede

Copy link
Copy Markdown
Contributor

@cipherstash-agent review

Copy link
Copy Markdown
Author

integration-test: received comment-command request from https://github.com/cipherstash/workflows/actions/runs/44664199061/attempts/2


Generated by Claude Code

Copy link
Copy Markdown
Author

integration-test: received comment-command request from https://github.com/cipherstash/workflows/actions/runs/44665882864/attempts/1


Generated by Claude Code

The live comment command check found that the 👀 reaction needs pull-requests: write, so v1.0.0 will be tagged after the fix.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012Jmn7nJnwMciggj9ThhFYj
The first live comment command (run 44665882864) sent the review request, but adding the 👀 reaction to the pull
request's comment failed with HTTP 403 for a token holding only issues: write. The react job, the example caller
and the self-test now also grant pull-requests: write, and a test keeps the three in step.

Refs #8

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012Jmn7nJnwMciggj9ThhFYj
… variable

The App is now named by the required app-client-id input, which callers fill from the organisation variable
CLAUDE_REVIEW_APP_CLIENT_ID, instead of the CLAUDE_REVIEW_APP_ID secret. actions/create-github-app-token deprecated
its app-id input in favour of client-id, and an ID is not secret, so a variable lets the setup script check it.
Only the private key stays a secret.

BREAKING CHANGE: callers pass app-client-id and no longer pass the CLAUDE_REVIEW_APP_ID secret.

Refs #8

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012Jmn7nJnwMciggj9ThhFYj
@cipherstash-agent cipherstash-agent changed the title ci(examples): pin the example caller to the v1.0.0 release fix!: let the 👀 reaction through, and name the membership App by its client ID Nov 20, 2026
@tobyhede
tobyhede merged commit 38f13f4 into main Nov 20, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants