Skip to content

Ready review requests end to end, gated on team membership, piloted in ore.rs #5

Closed

Description

@cipherstash-agent

Parent

#1

What to build

The first tracer bullet: the Ready kind of review request works end to end through the shared reusable workflow, gated on team membership, in one pilot repository.

A team member opens a non-draft pull request, reopens one, or marks a draft ready for review, and the shared workflow fires the routine trigger for that pull request. Pull requests that are drafts, from bots, from forks (including deleted forks), or opened by anyone who is not a team member get no review. If team membership cannot be checked, the request is skipped with a clear error in the run, and the check stays green.

cipherstash/ore.rs#143 is switched from its full copy to the short caller workflow, pinned to the commit SHA of this ticket's merge, and serves as the pilot.

Acceptance criteria

  • The reusable workflow exists and is called with the routine token and the membership App's id and private key (CLAUDE_REVIEW_APP_ID, CLAUDE_REVIEW_APP_PRIVATE_KEY) as explicit secrets, the routine trigger id as an input, and the team as an input defaulting to developers.
  • The request decision handles Ready: fires for opened, reopened and ready_for_review; skips drafts, bot authors, forks and deleted forks; skips non-team members; skips with an error when the membership lookup fails. Bot-authored pull requests are skipped before any lookup; a pull request opened by cipherstash-agent fires without a lookup (see the change on Spec: reusable Claude review workflow with comment and reviewer requests #1).
  • The routine trigger call keeps the existing hardening: token on standard input, trigger id checked against the trig_ format, request body built by jq, no retry, short timeouts, failures never turn the check red.
  • Untrusted text (titles, branch names) reaches scripts only through environment variables or the event payload file.
  • The Ready path runs with no repository permissions; one run per pull request at a time, never cancelling one in flight.
  • Saved-payload test cases cover every rule above, including an org member outside the team and a failed lookup.
  • The membership App's token, created for the cipherstash owner, reads developers team membership in a real run (this replaces the manual check in Create the membership GitHub App and its organization secrets #4).
  • ci: request a Claude code review when a pull request is ready ore.rs#143 uses the short caller workflow pinned by full SHA with a version comment, and marking it ready starts exactly one review.

Blocked by


Generated by Claude Code

Activity

  1. cipherstash-agent commented on Nov 17, 2026

    @cipherstash-agent
    Author

    Note from #10: a reusable workflow runs in the calling repository, so the request decision's files in this repository are not on disk there. This ticket needs to either fetch them from cipherstash/workflows at the same commit the caller pinned, or carry the jq program inline in the reusable workflow (and keep the tests running against that copy).


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

ready-for-agentFully specified, ready for an AFK agent

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions