Skip to content

Cut the sandbox and weekly live test down to what the self-test cannot cover #32

Open

Description

@cipherstash-agent

Parent

#1

What to build

Once the self-test covers ready requests, requested reviewers and the comment command, cut #18 (sandbox repository and test account) and #19 (weekly live smoke test) down to what the self-test cannot cover. The main gaps are a request from someone outside the team, a request from a person who is not the review agent (so the team membership lookup runs), and pull requests from forks.

Acceptance criteria

Blocked by


Generated by Claude Code

Activity

  1. cipherstash-agent commented on Nov 19, 2026

    @cipherstash-agent
    Author

    Proposed new scope for #18 and #19

    This is a draft. #18 and #19 are not changed yet, because this ticket is blocked until the self-test (#33, #34, #35) is merged and the comment command has run live from main.

    What the self-test now covers

    Check in #19 Covered by the self-test?
    Ready fires Yes. Proven live on #35: decision, HTTP 200 from the stub's trigger, and the stub's reply.
    Requested reviewer fires Built and unit-tested (#34). Not run live: GitHub does not let you request a review from a pull request's author, and cipherstash-agent opens most pull requests here.
    Comment command fires and gets 👀 Built and unit-tested (#35). Cannot run until the stack is on main.
    A comment that is not a command is skipped Yes: it starts no job.
    Uses only a test routine Yes: the stub routine.

    What is left for #18 and #19

    1. A request from a person who is not the review agent. Every live run so far was a pull request opened by cipherstash-agent, which skips the team membership lookup. A person's pull request, comment or reviewer request is needed to prove the lookup and the membership App's secrets in this repository. One team member doing this once on a pull request here would cover it, with no sandbox.
    2. A request from someone outside the team. The self-test goes red for this by design, so it cannot be an automatic check here. It needs a second account that is not in the team.
    3. Pull requests from forks. They get no secrets, so the self-test skips them.
    4. A weekly run. The self-test runs only when someone opens or marks ready a pull request. If the repository is quiet, nothing runs. Weekly live smoke test of the shared review workflow #19's weekly schedule would still need a way to make a real event, which is what the test account in Set up a sandbox repository and test account for live checks #18 is for.

    Suggested change


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

ready-for-agentFully specified, ready for an AFK agent

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions