Skip to content

Self-checkout at the pinned commit, proven with the jq request decision #22

Closed

Description

@cipherstash-agent

Parent

#20

What to build

The tracer bullet for #20, on #11's branch: the decide job checks out the workflows repository at the commit the caller pinned and runs the jq request decision from its own file. Nothing a caller or team member sees changes.

Acceptance criteria

  • The decide job's first step checks out the workflows repository at job.workflow_sha (or the fallback confirmed in the verification ticket): sparse, with no credentials persisted, at a path that cannot clash with the caller's files, with the checkout action pinned by full commit SHA.
  • A failed checkout ends in the decision-failed skip with an error annotation; no check turns red and nothing is fired.
  • The jq request decision lives in its own file, unchanged, and both decision steps run it from there.
  • The saved-case runner reads the jq file directly; every existing saved case passes unchanged.
  • Workflow-level permissions: {} is unchanged; the job gains no new permissions.
  • The ore.rs pilot caller is re-pinned to the new head and run once; the run shows the checkout of this repository at the pinned commit and a correct decision.
  • Merged up to feat: request a Claude review from a team member's comment command #12 and feat: request a Claude review when a team member requests the review agent #13 with merge commits; CI green on every head.

Blocked by


Generated by Claude Code

Activity

  1. cipherstash-agent commented on Nov 18, 2026

    @cipherstash-agent
    Author

    The live run on the ore.rs pilot passed

    The user ran the pilot on 19 November 2026: https://github.com/cipherstash/ore.rs/actions/runs/44423720239

    • Caller: ore.rs#143's caller (.github/workflows/code-review.yml, not claude-review.yml) was re-pinned to ecf98782c143559e87a2289e68abd0d68e1b9a05 in ore.rs commit 165fa56, then the pull request was marked ready for review.
    • Checkout: the decide and fire jobs both checked out cipherstash/workflows at ecf98782…. That confirms job.workflow_repository and job.workflow_sha resolve to this repository at the caller's pin. There was no 401, 403 or "Repository not found", so a job token with no contents permission can read this public repository. No contents: read is needed.
    • Decision: fire. The summary read "Claude review: requested (ready, by @cipherstash-agent, pull request #143)". The membership lookup was skipped, as expected for a pull request opened by cipherstash-agent.
    • Fire job: "Sent the review request to the routine trigger (HTTP 200)".
    • React job: skipped, as expected for an event that isn't a comment.

    Not covered by this run: a membership lookup for a real team member, the comment command (needs the caller on ore.rs's default branch), the requested reviewer, and the react job's checkout with an issues: write token.

    Every acceptance criterion of this ticket is now met. It closes when #11 merges.


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

ready-for-agentFully specified, ready for an AFK agent

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions