Skip to content

Move the decision fallback step to Python, with tests #17

Closed

Description

@cipherstash-agent

Related

Follow-up to #1.

What to build

The step that always leaves the fire job a valid decision becomes tested Python. Today a shell and jq step writes {"decision":"skip","reason":"decision-failed"} whenever the decision is missing, still asking for a lookup, or not valid JSON. It is rewritten in standard-library Python, inline in the reusable workflow, and tested with the harness from the membership lookup ticket.

Acceptance criteria

  • Behaviour is unchanged: a finished skip or fire decision passes through; a lookup decision, an empty value or anything that is not valid JSON becomes decision-failed with an error annotation; the job summary line is unchanged.
  • Step outputs are written safely for any value (a random delimiter or an equivalent guarantee).
  • The step cannot fail the decide job.
  • Unit tests cover a fire decision, a skip decision, a leftover lookup, an empty value, invalid JSON and a value containing newlines.

Blocked by


Generated by Claude Code

Activity

  1. cipherstash-agent commented on Nov 18, 2026

    @cipherstash-agent
    Author

    Plan change (2026-11-18): this is implemented inside the open stack instead of after the release, so no code is merged only to be replaced. It lands on #11's branch and is merged up the stack.


    Generated by Claude Code

  2. cipherstash-agent commented on Nov 18, 2026

    @cipherstash-agent
    Author

    Follow-up: #20 moves this step's code from the workflow file into a Python file the workflow checks out at its own commit (tickets #21–#27). Behaviour and tests stay the same; only where the code lives and how the tests find it change.


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

ready-for-agentFully specified, ready for an AFK agent

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions