Wrap GLTF material inventory uploads in binary LLSD - #175
Merged
cinderblocks merged 2 commits intoAug 22, 2026
Conversation
lyrae-versebound
marked this pull request as ready for review
August 21, 2026 03:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
version,type, and the material JSON in the envelopedatafieldMotivation
LibreMetaverse currently uploads raw GLTF JSON during the second stage, but the capability verifier expects the viewer-compatible binary LLSD material envelope. Wrapping the JSON as
version,type, anddatamatches the reference viewer behavior and allows the upload to complete.Validation
GLTFMaterialUploadTestsfixture passed 4/4 on net481, net8.0, net9.0, and net10.0 after the cancellation-token compatibility fixgit diff --checkpassedA separate full net9.0 suite was not run locally; local net9.0 validation was bounded to the affected fixture, exact regression, neighboring groups, and affected library build. Repository CI runs the complete cross-platform test matrix.
Breaking changes
None. This PR does not remove or rename any public API.
Limitations
Related issues
Fixes #172