Fix InventoryType wire values - #173
Merged
cinderblocks merged 1 commit intoAug 13, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Aligns InventoryType values and wire names with current Second Life definitions.
Changes:
- Corrects and extends enum values 23–28.
- Adds corresponding wire-name conversions.
- Adds regression tests for mappings and material creation.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
LibreMetaverse.Types/UtilsConversions.cs |
Extends inventory wire-name mappings. |
LibreMetaverse.Types/Enums.cs |
Corrects and adds inventory enum values. |
LibreMetaverse.Tests/InventoryManagerTests.cs |
Tests mappings and material instantiation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
cinderblocks
marked this pull request as ready for review
August 13, 2026 13:54
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Align the public
InventoryTypetail with the current Second Life wire values and extend the existing type-name table through GLTF binary assets.The corrected assignments are:
Widget = 23Person = 24Settings = 25Material = 26GLTF = 27GLTFBin = 28This intentionally corrects the existing public numeric values for
Settings(23to25) andMaterial(24to26). Consumers compiled against the old constants should rebuild against the corrected enum.The values and wire names are based on the authoritative Second Life Viewer definitions in
llinventorytype.handllinventorytype.cpp.Testing
InventoryMaterial.InventoryManagerTests: 10/10 passed.LibreMetaverse.Typesnet10.0 Release build: succeeded with no warnings or errors.The broader net10.0 test run is not completely green: 7 existing
HttpListener-based tests fail on this Windows environment with error code 6. The identical seven failures reproduce on the untouched base revision, while the candidate adds seven passing tests, so those failures are unrelated to this change.No live Agni validation was performed.
Fixes #170